Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/telemetry/telemetry/browser_backend.py

Issue 11740020: [telemetry] Removing globals from webpagereplay.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/browser.py ('k') | tools/telemetry/telemetry/wpr_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/browser_backend.py
diff --git a/tools/telemetry/telemetry/browser_backend.py b/tools/telemetry/telemetry/browser_backend.py
index ff55af41c353d24f47797650ab640374014612d9..a20c06aa7075d2d5f0e4568ac11f6ae029bd8db0 100644
--- a/tools/telemetry/telemetry/browser_backend.py
+++ b/tools/telemetry/telemetry/browser_backend.py
@@ -119,6 +119,11 @@ class TabController(object):
class BrowserBackend(object):
"""A base class for browser backends. Provides basic functionality
once a remote-debugger port has been established."""
+
+ WEBPAGEREPLAY_HOST = '127.0.0.1'
+ WEBPAGEREPLAY_HTTP_PORT = 8080
+ WEBPAGEREPLAY_HTTPS_PORT = 8413
+
def __init__(self, is_content_shell, options):
self.tabs = None
self.browser_type = options.browser_type
@@ -141,7 +146,9 @@ class BrowserBackend(object):
args.append('--metrics-recording-only')
args.append('--no-first-run')
if self.options.wpr_mode != wpr_modes.WPR_OFF:
- args.extend(wpr_server.CHROME_FLAGS)
+ args.extend(wpr_server.GetChromeFlags(self.WEBPAGEREPLAY_HOST,
+ self.WEBPAGEREPLAY_HTTP_PORT,
+ self.WEBPAGEREPLAY_HTTPS_PORT))
args.extend(user_agent.GetChromeUserAgentArgumentFromType(
self.options.browser_user_agent_type))
return args
« no previous file with comments | « tools/telemetry/telemetry/browser.py ('k') | tools/telemetry/telemetry/wpr_server.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698