Issue 11740009: Removed references to the old sourceDevice field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11740009: Removed references to the old sourceDevice field (Closed)

Created:
7 years, 11 months ago by mohsen

Modified:
7 years, 11 months ago

Reviewers:
rjkroege, no sievers

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removed references to the old sourceDevice field Now that the new sourceDevice field introduced in WebGestureEvent is used in WebKit, we can safely remove references to the old one (in WebGestureEvent::data.flingStart) in Chromium, so that the old one can be completely removed from WebKit. BUG=164389 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175463

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -17 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/gesture_event_filter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_unittest.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/ui_events_helper.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/web_input_event_aurax11.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mohsen

sievers@ for OWNERS in content/browser/android/content_view_core_impl.cc.

7 years, 11 months ago (2013-01-03 20:54:17 UTC) #3

no sievers

On 2013/01/03 20:54:17, mohsen wrote: > sievers@ for OWNERS in content/browser/android/content_view_core_impl.cc. lgtm

7 years, 11 months ago (2013-01-07 22:29:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohsen@chromium.org/11740009/1

7 years, 11 months ago (2013-01-07 22:32:25 UTC) #5

Message was sent while issue was closed.

Change committed as 175463

Expand Messages | Collapse Messages