Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 11737034: Make ~FormFieldData() not virtual. (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Make ~FormFieldData() not virtual. No one ever subclasses FormFieldData, and it has no (other) virtual methods. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/form_field_data.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
7 years, 11 months ago (2013-01-04 16:35:14 UTC) #1
Lei Zhang
lgtm
7 years, 11 months ago (2013-01-04 20:33:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11737034/1
7 years, 11 months ago (2013-01-04 23:23:36 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-04 23:35:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11737034/1
7 years, 11 months ago (2013-01-04 23:57:45 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-05 00:22:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11737034/1
7 years, 11 months ago (2013-01-05 00:35:29 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 01:27:13 UTC) #8
Message was sent while issue was closed.
Change committed as 175253

Powered by Google App Engine
This is Rietveld 408576698