"Lock on idle and suspend": Log out instead if session cannot be locked

"Lock on idle and suspend": Log out instead if session cannot be locked

This Cl ensures that if the current user's session cannot be locked,
"lock on idle suspend" triggers a logout instead.

BUG=168151
TEST=Manual


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175534

[bartfab (slow), 2013-01-03 12:47:44]

Hi Nikita,

Could you please review?

[bartfab (slow), 2013-01-08 14:00:54]

Hi Ivan,

As discussed, could you take a look?

[Ivan Korotkov, 2013-01-08 14:03:27]

lgtm

[commit-bot: I haz the power, 2013-01-08 14:04:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11737015/1

[commit-bot: I haz the power, 2013-01-08 15:58:26]

Change committed as 175534

[Nikita (slow), 2013-01-09 12:55:35]

https://chromiumcodereview.appspot.com/11737015/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/login/screen_locker.cc (right):

https://chromiumcodereview.appspot.com/11737015/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/screen_locker.cc:99:
chromeos::UserManager::Get()->CanCurrentUserLock()) {
I'm not sure that making logout in this case makes sense for all such cases.

It might be the case for public accounts but not for Guest session.

For Guest session we make sure that we never get here.
But even if we got here it should be a nop not a logout.

[bartfab (slow), 2013-01-10 11:12:01]

This CL is meant a stop-gap until the powerd rework is done (currently ongoing
and scheduled for M26). Once that lands, there will be fine-grained control over
idle/sleep/lock/power behavior and we will be able to configure Public Accounts
so that no attempt to lock is ever made.

In the meantime, we need a way to reinterpret "lock -> logout" for Public
Accounts. As you say, this does not make sense for e.g. Guest but as you also
mentioned, this code path should never be hit for anything but Public Accounts.

Long story short, we can modify the check from CanCurrentUserLock() to
IsLoggedInAsPublicAccount() for now. And in the near future, we will just remove
this code altogether.

On 2013/01/09 12:55:35, Nikita Kostylev wrote:
>
https://chromiumcodereview.appspot.com/11737015/diff/1/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/screen_locker.cc (right):
> 
>
https://chromiumcodereview.appspot.com/11737015/diff/1/chrome/browser/chromeo...
> chrome/browser/chromeos/login/screen_locker.cc:99:
> chromeos::UserManager::Get()->CanCurrentUserLock()) {
> I'm not sure that making logout in this case makes sense for all such cases.
> 
> It might be the case for public accounts but not for Guest session.
> 
> For Guest session we make sure that we never get here.
> But even if we got here it should be a nop not a logout.