Add robohornet as an animation test

Add robohornet as an animation test

Robohornet's main page is a good animation stress test (even without running the robohornet test).

Rather than hacking in a scrolling interaction, I decided to make a wait interaction since that's more appropriate for animation related smoothness tests.
It no longer made sense for the section in the page sets to be labeled "scrolling" any longer -- "smoothness" is more appropriate. I've made this change as well.

BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175188

[hartmanng, 2013-01-04 15:34:35]

https://codereview.chromium.org/11734036/diff/1/tools/perf/page_sets/animatio...
File tools/perf/page_sets/animations.json (right):

https://codereview.chromium.org/11734036/diff/1/tools/perf/page_sets/animatio...
tools/perf/page_sets/animations.json:9: "duration": "5"
I think you should be able to specify durations as numerical values instead of
strings (ie, just leave out the quotes). Then you wouldn't have to cast to int()
in wait_interaction.py.

https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
File tools/telemetry/telemetry/wait_interaction.py (right):

https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
tools/telemetry/telemetry/wait_interaction.py:36:
renderingStats.totalTimeInSeconds = getTimeMs() / 1000;
This may fail on legacy builds. We check for numFramesSentToScreen in
smoothness_benchmark.py.

https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
File tools/telemetry/telemetry/wait_interaction_unittest.py (right):

https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
tools/telemetry/telemetry/wait_interaction_unittest.py:20: i =
wait_interaction.WaitInteraction({ 'duration' : '1' })
Again here, it's probably easier to just have a number instead of string for the
duration value.

https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
tools/telemetry/telemetry/wait_interaction_unittest.py:26:
self.assertTrue(rendering_stats_deltas['totalTimeInSeconds'] > 0)
Might want to also check numFramesSentToScreen, just because
smoothness_benchmark.py expects it.

[Ian Vollick, 2013-01-04 16:40:33]

On 2013/01/04 15:34:35, hartmanng wrote:
>
https://codereview.chromium.org/11734036/diff/1/tools/perf/page_sets/animatio...
> File tools/perf/page_sets/animations.json (right):
> 
>
https://codereview.chromium.org/11734036/diff/1/tools/perf/page_sets/animatio...
> tools/perf/page_sets/animations.json:9: "duration": "5"
> I think you should be able to specify durations as numerical values instead of
> strings (ie, just leave out the quotes). Then you wouldn't have to cast to
int()
> in wait_interaction.py.
Sounds good. Done.
> 
>
https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
> File tools/telemetry/telemetry/wait_interaction.py (right):
> 
>
https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
> tools/telemetry/telemetry/wait_interaction.py:36:
> renderingStats.totalTimeInSeconds = getTimeMs() / 1000;
> This may fail on legacy builds. We check for numFramesSentToScreen in
> smoothness_benchmark.py.
The situation with numFramesSentToScreen is ugly during unit tests. I've logged
a bug, but I think that fixing it is outside the scope of this CL:
https://code.google.com/p/chromium/issues/detail?id=168346

> 
>
https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
> File tools/telemetry/telemetry/wait_interaction_unittest.py (right):
> 
>
https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
> tools/telemetry/telemetry/wait_interaction_unittest.py:20: i =
> wait_interaction.WaitInteraction({ 'duration' : '1' })
> Again here, it's probably easier to just have a number instead of string for
the
> duration value.
Done.
> 
>
https://codereview.chromium.org/11734036/diff/1/tools/telemetry/telemetry/wai...
> tools/telemetry/telemetry/wait_interaction_unittest.py:26:
> self.assertTrue(rendering_stats_deltas['totalTimeInSeconds'] > 0)
> Might want to also check numFramesSentToScreen, just because
> smoothness_benchmark.py expects it.
Same comment as above.

[hartmanng, 2013-01-04 16:44:35]

lgtm

[commit-bot: I haz the power, 2013-01-04 17:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/11734036/7001

[nduca, 2013-01-04 19:40:50]

Someone should go back through the other benchmarks and see if you can use this
elsewhere as well.

[nduca, 2013-01-04 19:41:41]

See for example the patch I have in flight,
https://codereview.chromium.org/11753023/

[commit-bot: I haz the power, 2013-01-04 20:35:22]

Change committed as 175188