Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11734034: Coverity: Remove default TabCaptureRequest constructor. (Closed)

Created:
7 years, 11 months ago by justinlin
Modified:
7 years, 11 months ago
Reviewers:
Matt Perry, kmadhusu
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Coverity: Remove default TabCaptureRequest constructor. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175269

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 8

Patch Set 3 : review comments #

Total comments: 3

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 2 3 5 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
justinlin
7 years, 11 months ago (2013-01-04 20:55:33 UTC) #1
kmadhusu
https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right): https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc#newcode138 chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:138: tab_capture::TabCaptureState state = it->second.status; You can avoid copying by ...
7 years, 11 months ago (2013-01-04 21:01:01 UTC) #2
Matt Perry
https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right): https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc#newcode83 chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:83: requests_.find(key)->second; This is not the same as the old ...
7 years, 11 months ago (2013-01-04 21:17:18 UTC) #3
justinlin
thanks, ptal https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right): https://codereview.chromium.org/11734034/diff/2001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc#newcode83 chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:83: requests_.find(key)->second; On 2013/01/04 21:17:18, Matt Perry wrote: ...
7 years, 11 months ago (2013-01-04 22:10:51 UTC) #4
Matt Perry
I still think there's no harm in having a default constructor, but I don't feel ...
7 years, 11 months ago (2013-01-04 22:21:35 UTC) #5
kmadhusu
https://codereview.chromium.org/11734034/diff/11001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right): https://codereview.chromium.org/11734034/diff/11001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc#newcode146 chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:146: const tab_capture::TabCaptureState& state = it->second.status; On 2013/01/04 22:21:35, Matt ...
7 years, 11 months ago (2013-01-04 22:31:06 UTC) #6
justinlin
https://codereview.chromium.org/11734034/diff/11001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc File chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc (right): https://codereview.chromium.org/11734034/diff/11001/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc#newcode146 chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc:146: const tab_capture::TabCaptureState& state = it->second.status; On 2013/01/04 22:31:06, kmadhusu ...
7 years, 11 months ago (2013-01-04 22:45:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11734034/16001
7 years, 11 months ago (2013-01-04 22:45:36 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-05 01:03:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11734034/16001
7 years, 11 months ago (2013-01-05 01:06:09 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 02:36:46 UTC) #11
Message was sent while issue was closed.
Change committed as 175269

Powered by Google App Engine
This is Rietveld 408576698