Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 11734031: Adding more api's to developer_private to enable / disable extensions. (Closed)

Created:
7 years, 11 months ago by Gaurav
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), tfarina, chromium-apps-reviews_chromium.org, Evan Stade
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

This CL adds more api's to developer_private to enable / disable extensions, load unpacked, uninstall, allow file access etc. It also adds the related UI code to display the apps. There are few API's which are still to be implemented like Pack-extension, allow-incognito etc. I will add them in the following CL. Also, browser tests to follow in the follow up CL. More APIs for AppsDebuggerPrivate. The AppsDebugger UI code is in 12021003 BUG=149036 TBR=sky@chromium.org TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177648

Patch Set 1 #

Patch Set 2 : removed unused files #

Patch Set 3 : Fixed CSP by overriding in manifest #

Patch Set 4 : Renamed "extension" to "item" #

Total comments: 23

Patch Set 5 : Addressed comments. Simplified DeveloperPrivateAPI class #

Patch Set 6 : . #

Total comments: 22

Patch Set 7 : Addressed comments. #

Total comments: 27

Patch Set 8 : Spliting the UI code in separate CL #

Patch Set 9 : Addressed comments #

Patch Set 10 : fixing compile on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -100 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 2 3 4 5 6 7 8 4 chunks +131 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 5 6 7 8 9 9 chunks +419 lines, -72 lines 0 comments Download
A chrome/browser/extensions/api/developer_private/entry_picker.h View 1 2 3 4 5 6 7 8 1 chunk +61 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/developer_private/entry_picker.cc View 1 2 3 4 5 6 7 8 1 chunk +100 lines, -0 lines 0 comments Download
M chrome/browser/resources/apps_debugger/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/apps_debugger/manifest.json View 1 2 3 4 5 6 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 2 3 4 5 6 7 8 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
grv1
7 years, 11 months ago (2013-01-04 21:11:50 UTC) #1
asargent_no_longer_on_chrome
https://codereview.chromium.org/11734031/diff/6001/chrome/browser/extensions/api/developer_private/developer_private_api.h File chrome/browser/extensions/api/developer_private/developer_private_api.h (right): https://codereview.chromium.org/11734031/diff/6001/chrome/browser/extensions/api/developer_private/developer_private_api.h#newcode50 chrome/browser/extensions/api/developer_private/developer_private_api.h:50: class DeveloperPrivateAPI : public ProfileKeyedService, I think it would ...
7 years, 11 months ago (2013-01-08 22:07:17 UTC) #2
Gaurav
Thanks Antony. Inline response to comments. With update with fixes. On 2013/01/08 22:07:17, Antony Sargent ...
7 years, 11 months ago (2013-01-09 01:02:56 UTC) #3
grv1
https://codereview.chromium.org/11734031/diff/6001/chrome/browser/extensions/api/developer_private/developer_private_api.h File chrome/browser/extensions/api/developer_private/developer_private_api.h (right): https://codereview.chromium.org/11734031/diff/6001/chrome/browser/extensions/api/developer_private/developer_private_api.h#newcode50 chrome/browser/extensions/api/developer_private/developer_private_api.h:50: class DeveloperPrivateAPI : public ProfileKeyedService, On 2013/01/08 22:07:17, Antony ...
7 years, 11 months ago (2013-01-11 19:50:37 UTC) #4
asargent_no_longer_on_chrome
Sorry to pile on so many additional change requests! At the end of the day ...
7 years, 11 months ago (2013-01-15 23:19:50 UTC) #5
miket_OOO
Small comment on CL metadata. The title should be economical, and it should summarize the ...
7 years, 11 months ago (2013-01-16 21:41:50 UTC) #6
miket_OOO
Also, if you want me to review this, please add miket (the other "Mike Tsao" ...
7 years, 11 months ago (2013-01-16 21:42:36 UTC) #7
Gaurav
Thanks for pointing that out, It took the first line of description as the title ...
7 years, 11 months ago (2013-01-17 02:02:26 UTC) #8
Gaurav
https://codereview.chromium.org/11734031/diff/16018/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/11734031/diff/16018/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode613 chrome/browser/extensions/api/developer_private/developer_private_api.cc:613: new EntryPicker(this, shell_window->web_contents(), picker_type, Yes, I saw similar pattern ...
7 years, 11 months ago (2013-01-17 02:04:11 UTC) #9
Gaurav
https://codereview.chromium.org/11734031/diff/16018/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/11734031/diff/16018/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode639 chrome/browser/extensions/api/developer_private/developer_private_api.cc:639: dict->SetString(id, l10n_util::GetStringUTF16(idr)) cc @estade : Any Ideas on this. ...
7 years, 11 months ago (2013-01-17 23:27:51 UTC) #10
asargent_no_longer_on_chrome
LGTM with a few things to fix before submitting https://codereview.chromium.org/11734031/diff/38001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/11734031/diff/38001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode78 chrome/browser/extensions/api/developer_private/developer_private_api.cc:78: ...
7 years, 11 months ago (2013-01-17 23:46:26 UTC) #11
Gaurav
https://codereview.chromium.org/11734031/diff/38001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/11734031/diff/38001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode78 chrome/browser/extensions/api/developer_private/developer_private_api.cc:78: break; I will adding an event listener to the ...
7 years, 11 months ago (2013-01-18 02:26:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/11734031/47002
7 years, 11 months ago (2013-01-18 02:48:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/11734031/50004
7 years, 11 months ago (2013-01-18 09:44:07 UTC) #14
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 12:24:25 UTC) #15
Message was sent while issue was closed.
Change committed as 177648

Powered by Google App Engine
This is Rietveld 408576698