Small extra validations on permission checks: reject "0" as a valid permission

Small extra validations on permission checks: reject "0" as a valid permission
mask and require the path be absolute.

Also add some per-file security owners to child_process_security_policy_impl.cc
since it is gughly sensitive.

[Charlie Reis, 2013-01-04 01:18:13]

LGTM, once you've landed the IsAbsolute() fix on Windows.  Good thinking on the
owners file.

[Charlie Reis, 2013-01-04 20:59:34]

https://codereview.chromium.org/11734030/diff/7001/content/browser/child_proc...
File content/browser/child_process_security_policy_unittest.cc (right):

https://codereview.chromium.org/11734030/diff/7001/content/browser/child_proc...
content/browser/child_process_security_policy_unittest.cc:356: FilePath
relative_file = FilePath(TEST_PATH("home/joe"));
Isn't this going to result in c:home/joe?  I suppose that's worth testing, but
so is "home/joe".

[Chris Evans, 2013-01-04 21:08:16]

On 2013/01/04 20:59:34, creis wrote:
>
https://codereview.chromium.org/11734030/diff/7001/content/browser/child_proc...
> File content/browser/child_process_security_policy_unittest.cc (right):
> 
>
https://codereview.chromium.org/11734030/diff/7001/content/browser/child_proc...
> content/browser/child_process_security_policy_unittest.cc:356: FilePath
> relative_file = FilePath(TEST_PATH("home/joe"));
> Isn't this going to result in c:home/joe?  I suppose that's worth testing, but
> so is "home/joe".

You're right, the use of TEST_PATH here was not my intention. Fixed.

[Charlie Reis, 2013-01-04 21:10:59]

LGTM.

[commit-bot: I haz the power, 2013-01-05 01:05:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cevans@chromium.org/11734030/13001

[commit-bot: I haz the power, 2013-01-05 02:01:12]

Retried try job too often on win_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-05 02:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cevans@chromium.org/11734030/13001

[commit-bot: I haz the power, 2013-01-05 02:58:26]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 20:52:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cevans@chromium.org/11734030/13001

[commit-bot: I haz the power, 2013-01-07 21:50:57]

Change committed as 175390