Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: net/base/host_resolver_impl.cc

Issue 11734020: Remove measurement of DNS resolution waste from not always performing AF_UNSPEC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl.cc
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index 4b6bb3ad1025b8ec5045e578e77211ef12ef6ea1..c54bf9dad5a384b1966b84f73d3833aaa60a2d94 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -1725,45 +1725,6 @@ int HostResolverImpl::Resolve(const RequestInfo& info,
JobMap::iterator jobit = jobs_.find(key);
Job* job;
if (jobit == jobs_.end()) {
- // If we couldn't find the desired address family, check to see if the
- // other family is in the cache or another job, which indicates waste,
- // and we should fix crbug.com/139811.
- {
- bool ipv4 = key.address_family == ADDRESS_FAMILY_IPV4;
- Key other_family_key = key;
- other_family_key.address_family = ipv4 ?
- ADDRESS_FAMILY_UNSPECIFIED : ADDRESS_FAMILY_IPV4;
- bool found_other_family_cache = false;
- bool found_other_family_job = false;
- if (default_address_family_ == ADDRESS_FAMILY_UNSPECIFIED) {
- found_other_family_cache = cache_.get() &&
- cache_->Lookup(other_family_key, base::TimeTicks::Now()) != NULL;
- if (!found_other_family_cache)
- found_other_family_job = jobs_.count(other_family_key) > 0;
- }
- enum { // Used in UMA_HISTOGRAM_ENUMERATION.
- AF_WASTE_IPV4_ONLY,
- AF_WASTE_CACHE_IPV4,
- AF_WASTE_CACHE_UNSPEC,
- AF_WASTE_JOB_IPV4,
- AF_WASTE_JOB_UNSPEC,
- AF_WASTE_NONE_IPV4,
- AF_WASTE_NONE_UNSPEC,
- AF_WASTE_MAX, // Bounding value.
- } category = AF_WASTE_MAX;
- if (default_address_family_ != ADDRESS_FAMILY_UNSPECIFIED) {
- category = AF_WASTE_IPV4_ONLY;
- } else if (found_other_family_cache) {
- category = ipv4 ? AF_WASTE_CACHE_IPV4 : AF_WASTE_CACHE_UNSPEC;
- } else if (found_other_family_job) {
- category = ipv4 ? AF_WASTE_JOB_IPV4 : AF_WASTE_JOB_UNSPEC;
- } else {
- category = ipv4 ? AF_WASTE_NONE_IPV4 : AF_WASTE_NONE_UNSPEC;
- }
- UMA_HISTOGRAM_ENUMERATION("DNS.ResolveUnspecWaste", category,
- AF_WASTE_MAX);
- }
-
job = new Job(weak_ptr_factory_.GetWeakPtr(), key, info.priority(),
request_net_log);
job->Schedule();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698