Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 11734007: cc: Don't activate pending tree until all tiles are ready (Closed)

Created:
7 years, 11 months ago by enne (OOO)
Modified:
7 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Don't activate pending tree until all tiles are ready Previously, we'd activate the pending tree if there were similar numbers of checkerboards, but this could cause unfortunate flashing. Now, only activate the tree if all the tiles in the 'now' bin (high-res, visible) are ready. NOTRY=true R=nduca@chromium.org BUG=155209 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175295

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M cc/layer_tree_host_impl.cc View 1 chunk +5 lines, -10 lines 1 comment Download

Messages

Total messages: 13 (0 generated)
enne (OOO)
7 years, 11 months ago (2013-01-02 22:54:02 UTC) #1
nduca
lgtm, but https://codereview.chromium.org/11734007/diff/1/cc/layer_tree_host_impl.cc File cc/layer_tree_host_impl.cc (left): https://codereview.chromium.org/11734007/diff/1/cc/layer_tree_host_impl.cc#oldcode1011 cc/layer_tree_host_impl.cc:1011: int total_active = m_tileManager->GetTilesInBinCount(NOW_BIN, ACTIVE_TREE); The more ...
7 years, 11 months ago (2013-01-05 04:51:49 UTC) #2
enne (OOO)
I hear you. I'll land this for now and will think about per-layer activation.
7 years, 11 months ago (2013-01-05 06:21:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11734007/1
7 years, 11 months ago (2013-01-05 06:22:06 UTC) #4
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 06:42:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11734007/1
7 years, 11 months ago (2013-01-05 06:46:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 07:03:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11734007/1
7 years, 11 months ago (2013-01-05 14:40:08 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 14:50:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11734007/1
7 years, 11 months ago (2013-01-05 20:38:09 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 20:48:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11734007/1
7 years, 11 months ago (2013-01-06 04:32:38 UTC) #12
commit-bot: I haz the power
7 years, 11 months ago (2013-01-06 05:08:19 UTC) #13
Message was sent while issue was closed.
Change committed as 175295

Powered by Google App Engine
This is Rietveld 408576698