Start removing [obj] characters from Contextual search panel.

Start removing [obj] characters from Contextual search panel.

Before Contextual Search gets back a resolution from the server we
show gray surrounding text for the given selection. This surrounding
text often contains [obj] characters for images. This CL removes such
characters.

This CL also adds me to OWNERS for this directory.

BUG=489826
Committed: https://crrev.com/cb71f9f7b183e8ce4dedcf2fd3ca90b2b7a02b66
Cr-Commit-Position: refs/heads/master@{#334091}

[aurimas (slooooooooow), 2015-06-11 01:09:17]

aurimas@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[aurimas (slooooooooow), 2015-06-11 01:09:18]

PTAL

[pedro (no code reviews), 2015-06-11 21:46:29]

lgtm

Thanks for fixing this annoying problem!

https://codereview.chromium.org/1173263002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java
(right):

https://codereview.chromium.org/1173263002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java:24:
private static final String OBJ_CHARACTER = "\uFFFC";
Nit: Please add a short comment explaining what is an object character, because
it might not be immediately obvious to others reading the code. At least, it
wasn't obvious to me by just reading at your CL title.

https://codereview.chromium.org/1173263002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OWNERS
(right):

https://codereview.chromium.org/1173263002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OWNERS:1:
aurimas@chromium.org
I don't see any differences here. Why is this file here?

[aurimas (slooooooooow), 2015-06-11 22:00:32]

https://chromiumcodereview.appspot.com/1173263002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java
(right):

https://chromiumcodereview.appspot.com/1173263002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java:24:
private static final String OBJ_CHARACTER = "\uFFFC";
On 2015/06/11 at 21:46:28, pedrosimonetti wrote:
> Nit: Please add a short comment explaining what is an object character,
because it might not be immediately obvious to others reading the code. At
least, it wasn't obvious to me by just reading at your CL title.

Done

https://chromiumcodereview.appspot.com/1173263002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OWNERS
(right):

https://chromiumcodereview.appspot.com/1173263002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/OWNERS:1:
aurimas@chromium.org
On 2015/06/11 at 21:46:28, pedrosimonetti wrote:
> I don't see any differences here. Why is this file here?

This is a brand new file. I was previously not an owner in this directory.

[aurimas (slooooooooow), 2015-06-11 22:00:46]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-06-11 22:00:47]

tedchoc: PTAL

[Ted C, 2015-06-11 22:21:43]

lgtm

https://chromiumcodereview.appspot.com/1173263002/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java
(right):

https://chromiumcodereview.appspot.com/1173263002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java:117:
mStartText.setText(start.replace(OBJ_CHARACTER, ""));
are these all guaranteed to be non-null?

[aurimas (slooooooooow), 2015-06-11 22:56:48]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-06-11 22:56:49]

https://chromiumcodereview.appspot.com/1173263002/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java
(right):

https://chromiumcodereview.appspot.com/1173263002/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchControl.java:117:
mStartText.setText(start.replace(OBJ_CHARACTER, ""));
On 2015/06/11 at 22:21:43, Ted C wrote:
> are these all guaranteed to be non-null?

Added a null check.

[aurimas (slooooooooow), 2015-06-11 22:56:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org, tedchoc@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1173263002/#ps80001
(title: "add null check")

[commit-bot: I haz the power, 2015-06-11 22:57:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1173263002/80001

[commit-bot: I haz the power, 2015-06-12 00:12:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-06-12 00:13:20]

Patchset 5 (id:??) landed as
https://crrev.com/cb71f9f7b183e8ce4dedcf2fd3ca90b2b7a02b66
Cr-Commit-Position: refs/heads/master@{#334091}