[Android WebView] Update SW rendering to use SkPicture and fix scrolling cases.

[Android WebView] Update SW rendering to use SkPicture and fix scrolling cases.

The new capturePicture API will now provide SkPicture objects rather than cc::PicturePileImpl. Update the code to reflect that.

Also, when rendering into separate layers in HW mode we're applying a translation to undo the Android Framework scrolling and let Chrome's compositor take care of it. This is not applicable to the layer case, however, as we only render ourselves out of our provided sufrace.

SW rendering doesn't need scroll correction after using SkPicture directly. Before, cc::PicturePileImpl translated the canvas as part of the content rect rasterization.

BUG=161409
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175781

[Leandro Graciá Gil, 2013-01-04 21:21:24]

https://codereview.chromium.org/11732002/diff/5001/android_webview/native/aw_...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/11732002/diff/5001/android_webview/native/aw_...
android_webview/native/aw_contents.cc:456: canvas.translate(scroll_x, scroll_y);
As part of the review of https://codereview.chromium.org/11731002/ I'll be
replacing all PicturePileImpl directly with SkPictures. It happens that then we
will translate the scroll to immediately undo that as PicturePileImpl::Raster
did to position itself correctly within the content.

So, apparently this translate and any references to scroll offsets in SW mode
can be removed and scroll will be automatically fixed when adopting SkPictures.
I'll update the patch.

[Leandro Graciá Gil, 2013-01-08 18:07:39]

Updating to SkPicture and simplifying the code.

[joth, 2013-01-08 20:48:23]

lgtm

https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw...
android_webview/native/aw_contents.cc:312: 
should we land this bit separately to the SkPicture changes?

[Leandro Graciá Gil, 2013-01-08 21:52:44]

https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw...
android_webview/native/aw_contents.cc:312: 
On 2013/01/08 20:48:23, joth wrote:
> should we land this bit separately to the SkPicture changes?

I'll do if you prefer so, although that will simply mean an extra code review.

[joth, 2013-01-08 21:55:49]

On 8 January 2013 13:52, <leandrogracia@chromium.org> wrote:

>
> https://codereview.chromium.**org/11732002/diff/13001/**
>
android_webview/native/aw_**contents.cc<https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw_contents.cc>
> File android_webview/native/aw_**contents.cc (right):
>
> https://codereview.chromium.**org/11732002/diff/13001/**
>
android_webview/native/aw_**contents.cc#newcode312<https://codereview.chromium.org/11732002/diff/13001/android_webview/native/aw_contents.cc#newcode312>
> android_webview/native/aw_**contents.cc:312:
> On 2013/01/08 20:48:23, joth wrote:
>
>> should we land this bit separately to the SkPicture changes?
>>
>
> I'll do if you prefer so, although that will simply mean an extra code
> review.
>
> If both bits are ready to submit now, please just go ahead and land it :).
Was just thinking if either side stalls no need to hold up the other



>
https://codereview.chromium.**org/11732002/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-01-09 00:43:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11732002/13001

[commit-bot: I haz the power, 2013-01-09 03:10:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-09 09:45:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leandrogracia@chromium.org/11732002/13001

[commit-bot: I haz the power, 2013-01-09 11:48:09]

Change committed as 175781