chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse

Patch Set: fixed HomepageURLManifestTest.GetHomepageURL Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index cef0a538bbffdc9808662b2691dda7de6bdbd38e..bdda3942c1e17081ff63c8976e71ace6175a0a0d 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -100,13 +100,14 @@ scoped_ptr<developer::ItemInfo> DeveloperPrivateAPI::CreateItemInfo(

info->homepage_url.reset(new std::string(

extensions::ManifestURL::GetHomepageURL(&item).spec()));

- if (!item.options_url().is_empty()) {

- info->options_url.reset(new std::string(item.options_url().spec()));

+ if (!ManifestURL::GetOptionsPage(&item).is_empty()) {

+ info->options_url.reset(

+ new std::string(ManifestURL::GetOptionsPage(&item).spec()));

}

- if (!item.update_url().is_empty()) {

- info->update_url.reset(new std::string(

- item.update_url().spec()));

+ if (!ManifestURL::GetUpdateURL(&item).is_empty()) {

+ info->update_url.reset(

+ new std::string(ManifestURL::GetUpdateURL(&item).spec()));

}

if (item.is_app()) {