Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 11724002: Move ContentScripts out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 9964a021d5c74ae61f0284fd5ffa684164d88ce8..c016f14a138c4b6063ac74a81eb8ddc40053d8ce 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -62,6 +62,7 @@
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/content_scripts/content_scripts_handler.h"
#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
#include "chrome/common/extensions/api/plugins/plugins_handler.h"
#include "chrome/common/extensions/background_info.h"
@@ -547,6 +548,7 @@ void ExtensionServiceTestBase::SetUp() {
testing::Test::SetUp();
ExtensionErrorReporter::GetInstance()->ClearErrors();
(new extensions::BackgroundManifestHandler)->Register();
+ (new extensions::ContentScriptsHandler)->Register();
(new extensions::DefaultLocaleHandler)->Register();
(new extensions::PluginsHandler)->Register();
}
@@ -1154,7 +1156,8 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectorySuccess) {
AddPattern(&expected_patterns, "http://*.google.com/*");
AddPattern(&expected_patterns, "https://*.google.com/*");
const Extension* extension = loaded_[0];
- const extensions::UserScriptList& scripts = extension->content_scripts();
+ const extensions::UserScriptList& scripts =
+ extensions::ContentScriptsInfo::GetContentScripts(extension);
ASSERT_EQ(2u, scripts.size());
EXPECT_EQ(expected_patterns, scripts[0].url_patterns());
EXPECT_EQ(2u, scripts[0].js_scripts().size());
@@ -1193,7 +1196,8 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectorySuccess) {
EXPECT_EQ(std::string(""), loaded_[1]->description());
EXPECT_EQ(loaded_[1]->GetResourceURL("background.html"),
extensions::BackgroundInfo::GetBackgroundURL(loaded_[1]));
- EXPECT_EQ(0u, loaded_[1]->content_scripts().size());
+ EXPECT_EQ(
+ 0u, extensions::ContentScriptsInfo::GetContentScripts(loaded_[1]).size());
// We don't parse the plugins section on Chrome OS.
#if defined(OS_CHROMEOS)
@@ -1218,7 +1222,9 @@ TEST_F(ExtensionServiceTest, LoadAllExtensionsFromDirectorySuccess) {
EXPECT_EQ(std::string(good2), loaded_[index]->id());
EXPECT_EQ(std::string("My extension 3"), loaded_[index]->name());
EXPECT_EQ(std::string(""), loaded_[index]->description());
- EXPECT_EQ(0u, loaded_[index]->content_scripts().size());
+ EXPECT_EQ(
+ 0u,
+ extensions::ContentScriptsInfo::GetContentScripts(loaded_[index]).size());
EXPECT_EQ(Manifest::INTERNAL, loaded_[index]->location());
};
@@ -2105,7 +2111,9 @@ TEST_F(ExtensionServiceTest, InstallTheme) {
ValidatePrefKeyCount(++pref_count);
ASSERT_TRUE(extension);
EXPECT_TRUE(extension->is_theme());
- EXPECT_EQ(0u, extension->content_scripts().size());
+ EXPECT_EQ(
+ 0u,
+ extensions::ContentScriptsInfo::GetContentScripts(extension).size());
}
// A theme with image resources missing (misspelt path).

Powered by Google App Engine
This is Rietveld 408576698