Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 11724002: Move ContentScripts out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_file_util.h" 5 #include "chrome/common/extensions/extension_file_util.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/json/json_string_value_serializer.h" 9 #include "base/json/json_string_value_serializer.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
11 #include "base/stringprintf.h" 11 #include "base/stringprintf.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "chrome/common/chrome_paths.h" 13 #include "chrome/common/chrome_paths.h"
14 #include "chrome/common/extensions/api/content_scripts/content_scripts_handler.h "
14 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h " 15 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "
15 #include "chrome/common/extensions/api/extension_action/page_action_handler.h" 16 #include "chrome/common/extensions/api/extension_action/page_action_handler.h"
16 #include "chrome/common/extensions/api/i18n/default_locale_handler.h" 17 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"
17 #include "chrome/common/extensions/api/icons/icons_handler.h" 18 #include "chrome/common/extensions/api/icons/icons_handler.h"
18 #include "chrome/common/extensions/background_info.h" 19 #include "chrome/common/extensions/background_info.h"
19 #include "chrome/common/extensions/extension.h" 20 #include "chrome/common/extensions/extension.h"
20 #include "chrome/common/extensions/extension_manifest_constants.h" 21 #include "chrome/common/extensions/extension_manifest_constants.h"
21 #include "chrome/common/extensions/manifest.h" 22 #include "chrome/common/extensions/manifest.h"
22 #include "chrome/common/extensions/manifest_handler.h" 23 #include "chrome/common/extensions/manifest_handler.h"
23 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
24 #include "testing/gmock/include/gmock/gmock.h" 25 #include "testing/gmock/include/gmock/gmock.h"
25 #include "testing/gtest/include/gtest/gtest.h" 26 #include "testing/gtest/include/gtest/gtest.h"
26 #include "ui/base/l10n/l10n_util.h" 27 #include "ui/base/l10n/l10n_util.h"
27 28
28 using extensions::Extension; 29 using extensions::Extension;
29 using extensions::Manifest; 30 using extensions::Manifest;
30 31
31 namespace keys = extension_manifest_keys; 32 namespace keys = extension_manifest_keys;
32 33
33 class ExtensionFileUtilTest : public testing::Test { 34 class ExtensionFileUtilTest : public testing::Test {
34 protected: 35 protected:
35 virtual void SetUp() OVERRIDE { 36 virtual void SetUp() OVERRIDE {
36 testing::Test::SetUp(); 37 testing::Test::SetUp();
37 (new extensions::BackgroundManifestHandler)->Register(); 38 (new extensions::BackgroundManifestHandler)->Register();
38 (new extensions::BrowserActionHandler)->Register(); 39 (new extensions::BrowserActionHandler)->Register();
39 (new extensions::DefaultLocaleHandler)->Register(); 40 (new extensions::DefaultLocaleHandler)->Register();
40 (new extensions::IconsHandler)->Register(); 41 (new extensions::IconsHandler)->Register();
41 (new extensions::PageActionHandler)->Register(); 42 (new extensions::PageActionHandler)->Register();
43 (new extensions::ContentScriptsHandler)->Register();
42 } 44 }
43 45
44 virtual void TearDown() OVERRIDE { 46 virtual void TearDown() OVERRIDE {
45 extensions::ManifestHandler::ClearRegistryForTesting(); 47 extensions::ManifestHandler::ClearRegistryForTesting();
46 } 48 }
47 }; 49 };
48 50
49 TEST_F(ExtensionFileUtilTest, InstallUninstallGarbageCollect) { 51 TEST_F(ExtensionFileUtilTest, InstallUninstallGarbageCollect) {
50 base::ScopedTempDir temp; 52 base::ScopedTempDir temp;
51 ASSERT_TRUE(temp.CreateUniqueTempDir()); 53 ASSERT_TRUE(temp.CreateUniqueTempDir());
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 scoped_refptr<Extension> extension3(extension_file_util::LoadExtension( 587 scoped_refptr<Extension> extension3(extension_file_util::LoadExtension(
586 ext_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error)); 588 ext_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
587 EXPECT_TRUE(extension3 == NULL); 589 EXPECT_TRUE(extension3 == NULL);
588 EXPECT_STREQ("Could not load icon 'icon.png' for page action.", 590 EXPECT_STREQ("Could not load icon 'icon.png' for page action.",
589 error.c_str()); 591 error.c_str());
590 } 592 }
591 593
592 // TODO(aa): More tests as motivation allows. Maybe steal some from 594 // TODO(aa): More tests as motivation allows. Maybe steal some from
593 // ExtensionService? Many of them could probably be tested here without the 595 // ExtensionService? Many of them could probably be tested here without the
594 // MessageLoop shenanigans. 596 // MessageLoop shenanigans.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698