Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: ipc/ipc_sync_message_filter.cc

Issue 11722033: reinterpret_cast -> static_cast in SyncMessageFilter::Send(). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_sync_message_filter.h" 5 #include "ipc/ipc_sync_message_filter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop_proxy.h" 10 #include "base/message_loop_proxy.h"
(...skipping 21 matching lines...) Expand all
32 32
33 if (!message->is_sync()) { 33 if (!message->is_sync()) {
34 io_loop_->PostTask( 34 io_loop_->PostTask(
35 FROM_HERE, base::Bind(&SyncMessageFilter::SendOnIOThread, this, message)); 35 FROM_HERE, base::Bind(&SyncMessageFilter::SendOnIOThread, this, message));
36 return true; 36 return true;
37 } 37 }
38 38
39 base::WaitableEvent done_event(true, false); 39 base::WaitableEvent done_event(true, false);
40 PendingSyncMsg pending_message( 40 PendingSyncMsg pending_message(
41 SyncMessage::GetMessageId(*message), 41 SyncMessage::GetMessageId(*message),
42 reinterpret_cast<SyncMessage*>(message)->GetReplyDeserializer(), 42 static_cast<SyncMessage*>(message)->GetReplyDeserializer(),
43 &done_event); 43 &done_event);
44 44
45 { 45 {
46 base::AutoLock auto_lock(lock_); 46 base::AutoLock auto_lock(lock_);
47 // Can't use this class on the main thread or else it can lead to deadlocks. 47 // Can't use this class on the main thread or else it can lead to deadlocks.
48 // Also by definition, can't use this on IO thread since we're blocking it. 48 // Also by definition, can't use this on IO thread since we're blocking it.
49 DCHECK(MessageLoopProxy::current() != listener_loop_); 49 DCHECK(MessageLoopProxy::current() != listener_loop_);
50 DCHECK(MessageLoopProxy::current() != io_loop_); 50 DCHECK(MessageLoopProxy::current() != io_loop_);
51 pending_sync_messages_.insert(&pending_message); 51 pending_sync_messages_.insert(&pending_message);
52 } 52 }
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 119
120 void SyncMessageFilter::SignalAllEvents() { 120 void SyncMessageFilter::SignalAllEvents() {
121 base::AutoLock auto_lock(lock_); 121 base::AutoLock auto_lock(lock_);
122 for (PendingSyncMessages::iterator iter = pending_sync_messages_.begin(); 122 for (PendingSyncMessages::iterator iter = pending_sync_messages_.begin();
123 iter != pending_sync_messages_.end(); ++iter) { 123 iter != pending_sync_messages_.end(); ++iter) {
124 (*iter)->done_event->Signal(); 124 (*iter)->done_event->Signal();
125 } 125 }
126 } 126 }
127 127
128 } // namespace IPC 128 } // namespace IPC
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698