Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: vm/object.h

Issue 11722026: Do not emit pointer information for embedded singleton VM Isolate objects while generating code. Th… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/assembler_ia32.cc ('K') | « vm/heap.cc ('k') | vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.h
===================================================================
--- vm/object.h (revision 16624)
+++ vm/object.h (working copy)
@@ -202,6 +202,16 @@
bool IsNew() const { return raw()->IsNewObject(); }
bool IsOld() const { return raw()->IsOldObject(); }
+ bool InVMHeap() const {
+#if defined(DEBUG)
+ if (raw()->IsVMHeapObject()) {
+ Heap* vm_isolate_heap = Dart::vm_isolate()->heap();
+ ASSERT(vm_isolate_heap->Contains(reinterpret_cast<uword>(raw_->ptr())));
Ivan Posva 2013/01/04 06:42:07 ...->Contains(RawObject::ToAddr(raw_))
siva 2013/01/04 18:36:10 Done.
+ }
+#endif
+ ASSERT(!Isolate::Current()->heap()->gc_in_progress());
Ivan Posva 2013/01/04 06:42:07 Can you move this assertion into the RawObject cod
siva 2013/01/04 18:36:10 Done.
+ return raw()->IsVMHeapObject();
+ }
// Print the object on stdout for debugging.
void Print() const;
« vm/assembler_ia32.cc ('K') | « vm/heap.cc ('k') | vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698