Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: vm/assembler_ia32.cc

Issue 11722026: Do not emit pointer information for embedded singleton VM Isolate objects while generating code. Th… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/assembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/assembler_ia32.cc
===================================================================
--- vm/assembler_ia32.cc (revision 16644)
+++ vm/assembler_ia32.cc (working copy)
@@ -1553,7 +1553,7 @@
void Assembler::LoadObject(Register dst, const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
movl(dst, Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsNotTemporaryScopedHandle());
@@ -1566,7 +1566,7 @@
void Assembler::PushObject(const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
pushl(Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsNotTemporaryScopedHandle());
@@ -1579,7 +1579,7 @@
void Assembler::CompareObject(Register reg, const Object& object) {
- if (object.IsSmi() || object.IsNull()) {
+ if (object.IsSmi() || object.InVMHeap()) {
cmpl(reg, Immediate(reinterpret_cast<int32_t>(object.raw())));
} else {
ASSERT(object.IsNotTemporaryScopedHandle());
@@ -1655,7 +1655,7 @@
void Assembler::StoreIntoObjectNoBarrier(Register object,
const FieldAddress& dest,
const Object& value) {
- if (value.IsSmi()) {
+ if (value.IsSmi() || value.InVMHeap()) {
movl(dest, Immediate(reinterpret_cast<int32_t>(value.raw())));
} else {
// No heap trace for an old object store.
« no previous file with comments | « no previous file | vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698