Validate texture sizes given to VDA

content/common/gpu/media/gpu_video_decode_accelerator.cc

Index: content/common/gpu/media/gpu_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.cc b/content/common/gpu/media/gpu_video_decode_accelerator.cc
index 7e76095f5c6795f0404938e9dab2163e6a572302..e6b1f85eedb9714fa270c435e34979113f6ee833 100644
--- a/content/common/gpu/media/gpu_video_decode_accelerator.cc
+++ b/content/common/gpu/media/gpu_video_decode_accelerator.cc
@@ -231,6 +231,13 @@ void GpuVideoDecodeAccelerator::OnAssignPictureBuffers(
       NotifyError(media::VideoDecodeAccelerator::INVALID_ARGUMENT);
       return;
     }
+    GLsizei width, height;
+    info->GetLevelSize(0, 0, &width, &height);

[dwkang1, 2013/01/15 08:17:46]

crbug says I don't have permission for 168293. So I leave a comment here.

Could you check this works well in Debug build? It seems that this line leads to
a DCHECK error in texture_manager.cc:37. According to the GetLevelSize() code,
the first argument of this call should be texture target.

[sheu, 2013/01/15 08:25:38]

It looks like you're right; I'll have to follow-up on this CL.  It turns out the
"face" argument isn't "face index", but "face target": 

http://code.google.com/searchframe#OAMlx_jo-ck/src/gpu/command_buffer/service...

Behavior is still correct in release build; we hit a NOTREACHED(), but default
to 0, which is what we want.  Still need to fix though.

+    if (width != sizes[i].width() || height != sizes[i].height()) {
+      DLOG(FATAL) << "Size mismatch for texture id " << texture_ids[i];
+      NotifyError(media::VideoDecodeAccelerator::INVALID_ARGUMENT);
+      return;
+    }
     if (!texture_manager->ClearRenderableLevels(command_decoder, info)) {
       DLOG(FATAL) << "Failed to Clear texture id " << texture_ids[i];
       NotifyError(media::VideoDecodeAccelerator::PLATFORM_FAILURE);