Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 11720005: Remove a mysterious manual deletion of the (sync message) reply deserializer. (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove a mysterious manual deletion of the (sync message) reply deserializer. The message is deleted on the following line. (And GetReplyDeserializer() does nothing other than release and return a scoped_ptr member. And yes, Messages have virtual destructors.) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/common/extensions/extension_localization_peer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
7 years, 11 months ago (2013-01-04 16:45:41 UTC) #1
Yoyo Zhou
shrug, LGTM
7 years, 11 months ago (2013-01-04 17:57:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11720005/1
7 years, 11 months ago (2013-01-04 19:14:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-04 20:59:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11720005/1
7 years, 11 months ago (2013-01-04 23:23:19 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 00:43:47 UTC) #6
Message was sent while issue was closed.
Change committed as 175243

Powered by Google App Engine
This is Rietveld 408576698