Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 11699005: In iossim, ignore harmless messages from launchd. (Closed)

Created:
7 years, 12 months ago by lliabraa
Modified:
7 years, 11 months ago
Reviewers:
TVL
CC:
chromium-reviews, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

In iossim, ignore harmless messages from launchd. iossim checks the system log for messages from launchd about the simulated app and returns failure if anything is found. Some messages are harmless, so this CL updates iossim to log them but not return failure. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174802

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M testing/iossim/iossim.mm View 1 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lliabraa
7 years, 12 months ago (2012-12-28 17:34:31 UTC) #1
TVL
lgtm https://codereview.chromium.org/11699005/diff/1/testing/iossim/iossim.mm File testing/iossim/iossim.mm (right): https://codereview.chromium.org/11699005/diff/1/testing/iossim/iossim.mm#newcode288 testing/iossim/iossim.mm:288: BOOL entryFound = NO; maybe change this to ...
7 years, 12 months ago (2012-12-28 23:47:53 UTC) #2
lliabraa
Thanks for the review. https://chromiumcodereview.appspot.com/11699005/diff/1/testing/iossim/iossim.mm File testing/iossim/iossim.mm (right): https://chromiumcodereview.appspot.com/11699005/diff/1/testing/iossim/iossim.mm#newcode288 testing/iossim/iossim.mm:288: BOOL entryFound = NO; On ...
7 years, 11 months ago (2013-01-02 11:48:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/11699005/5001
7 years, 11 months ago (2013-01-02 11:48:49 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-02 13:41:34 UTC) #5
Message was sent while issue was closed.
Change committed as 174802

Powered by Google App Engine
This is Rietveld 408576698