src/ia32/macro-assembler-ia32.cc - Issue 11695006: Cleanup RelocInfo::NONE usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 11695006: Cleanup RelocInfo::NONE usage. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 7b41defabfecd86fbf47cfe8206e59f099f40591..3127bfcdb82ff1532d3b4b8a3073f85cdc19cf5d 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -406,7 +406,7 @@ void MacroAssembler::Set(const Operand& dst, const Immediate& x) {

bool MacroAssembler::IsUnsafeImmediate(const Immediate& x) {

static const int kMaxImmediateBits = 17;

- if (x.rmode_ != RelocInfo::NONE) return false;

+ if (RelocInfo::IsNone(x.rmode_)) return false;

ulan 2013/01/03 12:46:22 This should be: if (!RelocInfo::IsNone(x.rmode_))

JF 2013/01/03 16:25:03 Ah yes, sorry about that! Did you also fix that on

return !is_intn(x.x_, kMaxImmediateBits);

}