Issue 11695006: Cleanup RelocInfo::NONE usage.

Issue 11695006: Cleanup RelocInfo::NONE usage. (Closed)

Created:
7 years, 12 months ago by JF

Modified:
7 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup RelocInfo::NONE usage. There are now NONE and NONE64 RelocInfo types, but only ARM uses them both at the same time. They were added in: https://chromiumcodereview.appspot.com/11191029/ I'll rename NONE to NONE32 in a later CL. This CL cleans up the RelocInfo::NONE usage by: - Using RelocInfo::IsNone when testing for NONE-ness. - Using NONE on 32-bit platforms (MIPS and IA32), and NONE64 on 64-bit platforms (x64). This cleans up the code and prevents it from evolving bugs in the future because NONE32 and NONE64 are used in misleading ways. R= ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13307

Patch Set 1 #

Total comments: 4

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -62 lines)			Patch
M	src/ia32/assembler-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+1 line, -1 line	2 comments	Download
M	src/mips/assembler-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	10 chunks	+11 lines, -11 lines	2 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	11 chunks	+15 lines, -15 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-macro-assembler-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM. I will fix the nits and land it for you. https://chromiumcodereview.appspot.com/11695006/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): ...

7 years, 11 months ago (2013-01-03 10:37:10 UTC) #2

ulan

I missed a bug in the first review. I'll fix it before landing. https://chromiumcodereview.appspot.com/11695006/diff/1/src/ia32/macro-assembler-ia32.cc File ...

7 years, 11 months ago (2013-01-03 12:46:22 UTC) #4

https://chromiumcodereview.appspot.com/11695006/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://chromiumcodereview.appspot.com/11695006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode409 src/ia32/macro-assembler-ia32.cc:409: if (RelocInfo::IsNone(x.rmode_)) return false; On 2013/01/03 12:46:22, ulan wrote: ...

7 years, 11 months ago (2013-01-03 16:25:03 UTC) #5

7 years, 11 months ago (2013-01-03 16:27:00 UTC) #6

Message was sent while issue was closed.

I read half of your comment.

I'll now do the other part of this change (rename to NONE32).

Expand Messages | Collapse Messages