Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 11693003: mac: Move the bookmark bar overflow chevron from pdf to png (Closed)

Created:
7 years, 12 months ago by Nico
Modified:
7 years, 12 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

mac: Move the bookmark bar overflow chevron from pdf to png BUG=111101 TEST=Bookmark many things, look at the overflow chevron. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174726

Patch Set 1 #

Patch Set 2 : noscale #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -246 lines) Patch
M chrome/app/nibs/BookmarkBar.xib View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/app/theme/chevron.pdf View 1 2 1 chunk +0 lines, -239 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
This one's easy too, but the png looks pretty horrible so I'll have to ask ...
7 years, 12 months ago (2012-12-27 23:24:32 UTC) #1
sail
Agree that the PNG looks terrible. LGTM for the code changes.
7 years, 12 months ago (2012-12-27 23:27:39 UTC) #2
Nico
On 2012/12/27 23:27:39, sail wrote: > Agree that the PNG looks terrible. LGTM for the ...
7 years, 12 months ago (2012-12-28 04:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11693003/6001
7 years, 12 months ago (2012-12-28 04:00:31 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_dll_bundle.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 12 months ago (2012-12-28 04:00:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11693003/8001
7 years, 12 months ago (2012-12-28 04:06:11 UTC) #6
commit-bot: I haz the power
7 years, 12 months ago (2012-12-28 05:56:20 UTC) #7
Message was sent while issue was closed.
Change committed as 174726

Powered by Google App Engine
This is Rietveld 408576698