Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 11691003: mac: Replace notification wrench pdf with a png (Closed)

Created:
7 years, 12 months ago by Nico
Modified:
7 years, 12 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

mac: Replace notification wrench pdf with a png BUG=111101 TEST=If on 10.8, change NotificationUIManager::Create() to always create non-native notifications. Go to http://dangercove.github.com/html5-notifications/ and create a plain text notification, the wrench image should show up fine in normal, hover, and pressed states. Before: http://imgur.com/yBAz0,XM7fI#0 After: http://imgur.com/yBAz0,XM7fI#1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174717

Patch Set 1 #

Patch Set 2 : notest #

Patch Set 3 : notest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
D chrome/app/theme/balloon_wrench.pdf View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 chunk +9 lines, -6 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Looks like this one is easy.
7 years, 12 months ago (2012-12-27 23:01:19 UTC) #1
sail
Sweet! LGTM
7 years, 12 months ago (2012-12-27 23:05:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11691003/1005
7 years, 12 months ago (2012-12-27 23:22:52 UTC) #3
commit-bot: I haz the power
7 years, 12 months ago (2012-12-28 01:50:40 UTC) #4
Message was sent while issue was closed.
Change committed as 174717

Powered by Google App Engine
This is Rietveld 408576698