Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4325)

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 11689004: Move PromoResourceService from Profile to BrowserProcessImpl/local_state(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android x 4 Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.h
diff --git a/chrome/browser/web_resource/promo_resource_service.h b/chrome/browser/web_resource/promo_resource_service.h
index e55e59a0ac478b99b5f1aa4340ab5051129b41c1..21b0143a1fd8b2e77b06abca0bac2e33cccce30d 100644
--- a/chrome/browser/web_resource/promo_resource_service.h
+++ b/chrome/browser/web_resource/promo_resource_service.h
@@ -17,7 +17,6 @@ class DictionaryValue;
class NotificationPromo;
class PrefServiceSimple;
class PrefServiceSyncable;
-class Profile;
// A PromoResourceService fetches data from a web resource server to be used to
// dynamically change the appearance of the New Tab Page. For example, it has
@@ -26,10 +25,9 @@ class Profile;
class PromoResourceService : public WebResourceService {
public:
static void RegisterPrefs(PrefServiceSimple* local_state);
-
static void RegisterUserPrefs(PrefServiceSyncable* prefs);
- explicit PromoResourceService(Profile* profile);
+ explicit PromoResourceService(PrefServiceSimple* prefs);
private:
virtual ~PromoResourceService();
@@ -55,8 +53,8 @@ class PromoResourceService : public WebResourceService {
// WebResourceService override to process the parsed information.
virtual void Unpack(const base::DictionaryValue& parsed_json) OVERRIDE;
- // The profile this service belongs to.
- Profile* profile_;
+ // The preference service that promos are written to when received.
+ PrefServiceSimple* prefs_;
// Allows the creation of tasks to send a notification.
// This allows the PromoResourceService to notify the New Tab Page immediately

Powered by Google App Engine
This is Rietveld 408576698