Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 11689004: Move PromoResourceService from Profile to BrowserProcessImpl/local_state(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_ 5 #ifndef CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_
6 #define CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_ 6 #define CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "chrome/browser/web_resource/web_resource_service.h" 11 #include "chrome/browser/web_resource/web_resource_service.h"
12 12
13 namespace base { 13 namespace base {
14 class DictionaryValue; 14 class DictionaryValue;
15 } 15 }
16 16
17 class NotificationPromo; 17 class NotificationPromo;
18 class PrefService;
18 class PrefServiceSimple; 19 class PrefServiceSimple;
19 class PrefServiceSyncable; 20 class PrefServiceSyncable;
20 class Profile;
21 21
22 // A PromoResourceService fetches data from a web resource server to be used to 22 // A PromoResourceService fetches data from a web resource server to be used to
23 // dynamically change the appearance of the New Tab Page. For example, it has 23 // dynamically change the appearance of the New Tab Page. For example, it has
24 // been used to fetch "tips" to be displayed on the NTP, or to display 24 // been used to fetch "tips" to be displayed on the NTP, or to display
25 // promotional messages to certain groups of Chrome users. 25 // promotional messages to certain groups of Chrome users.
26 class PromoResourceService : public WebResourceService { 26 class PromoResourceService : public WebResourceService {
27 public: 27 public:
28 static void RegisterPrefs(PrefServiceSimple* local_state); 28 static void RegisterPrefs(PrefServiceSimple* local_state);
29
30 static void RegisterUserPrefs(PrefServiceSyncable* prefs); 29 static void RegisterUserPrefs(PrefServiceSyncable* prefs);
31 30
32 explicit PromoResourceService(Profile* profile); 31 PromoResourceService();
33 32
34 private: 33 private:
35 virtual ~PromoResourceService(); 34 virtual ~PromoResourceService();
36 35
36 // For testing.
37 PromoResourceService(PrefService* prefs);
38 void ScheduleNotificationOnInitForTesting(PrefService* prefs);
39 friend class PromoResourceServiceTest;
Robert Sesek 2013/01/03 21:40:10 friends come first
Dan Beam 2013/01/03 22:47:38 Done. (not needed any more)
40
37 // Schedule a notification that a web resource is either going to become 41 // Schedule a notification that a web resource is either going to become
38 // available or be no longer valid. 42 // available or be no longer valid.
39 void ScheduleNotification(const NotificationPromo& notification_promo); 43 void ScheduleNotification(const NotificationPromo& notification_promo);
40 44
41 // Schedules the initial notification for when the web resource is going 45 // Schedules the initial notification for when the web resource is going
42 // to become available or no longer valid. This performs a few additional 46 // to become available or no longer valid. This performs a few additional
43 // checks than ScheduleNotification, namely it schedules updates immediately 47 // checks than ScheduleNotification, namely it schedules updates immediately
44 // if the promo service or Chrome locale has changed. 48 // if the promo service or Chrome locale has changed.
45 void ScheduleNotificationOnInit(); 49 void ScheduleNotificationOnInit();
46 50
47 // If delay_ms is positive, schedule notification with the delay. 51 // If delay_ms is positive, schedule notification with the delay.
48 // If delay_ms is 0, notify immediately by calling WebResourceStateChange(). 52 // If delay_ms is 0, notify immediately by calling WebResourceStateChange().
49 // If delay_ms is negative, do nothing. 53 // If delay_ms is negative, do nothing.
50 void PostNotification(int64 delay_ms); 54 void PostNotification(int64 delay_ms);
51 55
52 // Notify listeners that the state of a web resource has changed. 56 // Notify listeners that the state of a web resource has changed.
53 void PromoResourceStateChange(); 57 void PromoResourceStateChange();
54 58
55 // WebResourceService override to process the parsed information. 59 // WebResourceService override to process the parsed information.
56 virtual void Unpack(const base::DictionaryValue& parsed_json) OVERRIDE; 60 virtual void Unpack(const base::DictionaryValue& parsed_json) OVERRIDE;
57 61
58 // The profile this service belongs to.
59 Profile* profile_;
60
61 // Allows the creation of tasks to send a notification. 62 // Allows the creation of tasks to send a notification.
62 // This allows the PromoResourceService to notify the New Tab Page immediately 63 // This allows the PromoResourceService to notify the New Tab Page immediately
63 // when a new web resource should be shown or removed. 64 // when a new web resource should be shown or removed.
64 base::WeakPtrFactory<PromoResourceService> weak_ptr_factory_; 65 base::WeakPtrFactory<PromoResourceService> weak_ptr_factory_;
65 66
66 DISALLOW_COPY_AND_ASSIGN(PromoResourceService); 67 DISALLOW_COPY_AND_ASSIGN(PromoResourceService);
67 }; 68 };
68 69
69 #endif // CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_ 70 #endif // CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698