Issue 11688003: Revert r13275 and 13276 (Remove most uses of StringInputBuffer).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11688003: Revert r13275 and 13276 (Remove most uses of StringInputBuffer). (Closed)

Created:
7 years, 12 months ago by Yang

Modified:
7 years, 12 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert r13275 and 13276 (Remove most uses of StringInputBuffer). This is due to test failures in test-mark-compact/BootUpMemoryUse. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13277

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+250 lines, -324 lines)			Patch
M	src/api.cc	View	6 chunks	+9 lines, -7 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/isolate.h	View	5 chunks	+12 lines, -12 lines	0 comments	Download
M	src/isolate.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/objects.cc	View	15 chunks	+123 lines, -186 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	src/runtime.cc	View	9 chunks	+41 lines, -40 lines	0 comments	Download
M	src/string-stream.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/v8conversions.cc	View	5 chunks	+18 lines, -22 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

On 2012/12/27 10:02:27, Yang wrote:

LGTM (rubber-stamp)