Remove some Profile-keyed factory boilerplate: management omnibox preference push_messaging.

chrome/browser/extensions/api/management/management_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_
 
 #include "base/compiler_specific.h"
+#include "chrome/browser/extensions/api/profile_keyed_api_factory.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 
 class ExtensionService;
 class ExtensionUninstallDialog;
 
-class ExtensionManagementFunction : public SyncExtensionFunction {
+namespace extensions {
+
+class ManagementFunction : public SyncExtensionFunction {
  protected:
-  virtual ~ExtensionManagementFunction() {}
+  virtual ~ManagementFunction() {}
 
   ExtensionService* service();
 };
 
-class AsyncExtensionManagementFunction : public AsyncExtensionFunction {
+class AsyncManagementFunction : public AsyncExtensionFunction {
  protected:
-  virtual ~AsyncExtensionManagementFunction() {}
+  virtual ~AsyncManagementFunction() {}
 
   ExtensionService* service();
 };
 
-class GetAllExtensionsFunction : public ExtensionManagementFunction {
+class GetAllExtensionsFunction : public ManagementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.getAll");
 
  protected:
   virtual ~GetAllExtensionsFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
-class GetExtensionByIdFunction : public ExtensionManagementFunction {
+class GetExtensionByIdFunction : public ManagementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.get");
 
  protected:
   virtual ~GetExtensionByIdFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
-class GetPermissionWarningsByIdFunction : public ExtensionManagementFunction {
+class GetPermissionWarningsByIdFunction : public ManagementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.getPermissionWarningsById");
 
  protected:
   virtual ~GetPermissionWarningsByIdFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
 class GetPermissionWarningsByManifestFunction : public AsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME(
       "management.getPermissionWarningsByManifest");
 
   // Called when utility process finishes.
   void OnParseSuccess(base::DictionaryValue* parsed_manifest);
   void OnParseFailure(const std::string& error);
 
  protected:
   virtual ~GetPermissionWarningsByManifestFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
-class LaunchAppFunction : public ExtensionManagementFunction {
+class LaunchAppFunction : public ManagementFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.launchApp");
 
  protected:
   virtual ~LaunchAppFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
-class SetEnabledFunction : public AsyncExtensionManagementFunction,
+class SetEnabledFunction : public AsyncManagementFunction,
                            public ExtensionInstallPrompt::Delegate {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.setEnabled");
 
   SetEnabledFunction();
 
  protected:
   virtual ~SetEnabledFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
   // ExtensionInstallPrompt::Delegate.
   virtual void InstallUIProceed() OVERRIDE;
   virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
 
  private:
   std::string extension_id_;
 
   // Used for prompting to re-enable items with permissions escalation updates.
   scoped_ptr<ExtensionInstallPrompt> install_prompt_;
 };
 
-class UninstallFunction : public AsyncExtensionManagementFunction,
+class UninstallFunction : public AsyncManagementFunction,
                           public ExtensionUninstallDialog::Delegate {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("management.uninstall");
 
   UninstallFunction();
   static void SetAutoConfirmForTest(bool should_proceed);
 
   // ExtensionUninstallDialog::Delegate implementation.
   virtual void ExtensionUninstallAccepted() OVERRIDE;
   virtual void ExtensionUninstallCanceled() OVERRIDE;
 
  private:
   virtual ~UninstallFunction();
 
   virtual bool RunImpl() OVERRIDE;
 
   // If should_uninstall is true, this method does the actual uninstall.
   // If |show_uninstall_dialog|, then this function will be called by one of the
   // Accepted/Canceled callbacks. Otherwise, it's called directly from RunImpl.
   void Finish(bool should_uninstall);
 
   std::string extension_id_;
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
 };
 
-class ExtensionManagementEventRouter : public content::NotificationObserver {
+class ManagementEventRouter : public content::NotificationObserver {
  public:
-  explicit ExtensionManagementEventRouter(Profile* profile);
-  virtual ~ExtensionManagementEventRouter();
+  explicit ManagementEventRouter(Profile* profile);
+  virtual ~ManagementEventRouter();
 
  private:
   // content::NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   content::NotificationRegistrar registrar_;
 
   Profile* profile_;
 
-  DISALLOW_COPY_AND_ASSIGN(ExtensionManagementEventRouter);
+  DISALLOW_COPY_AND_ASSIGN(ManagementEventRouter);
 };
 
-class ExtensionManagementAPI : public ProfileKeyedService,
-                               public extensions::EventRouter::Observer {
+class ManagementAPI : public ProfileKeyedAPI,
+                      public extensions::EventRouter::Observer {
  public:
-  explicit ExtensionManagementAPI(Profile* profile);
-  virtual ~ExtensionManagementAPI();
+  explicit ManagementAPI(Profile* profile);
+  virtual ~ManagementAPI();
 
   // ProfileKeyedService implementation.
   virtual void Shutdown() OVERRIDE;
 
   // EventRouter::Observer implementation.
   virtual void OnListenerAdded(const extensions::EventListenerInfo& details)
       OVERRIDE;
 
  private:
+  friend class ProfileKeyedAPIFactory<ManagementAPI>;
+
   Profile* profile_;
 
+  // ProfileKeyedAPI implementation.
+  static const char* service_name() {
+    return "ManagementAPI";
+  }
+  static const bool kServiceIsNULLWhileTesting = true;
+
   // Created lazily upon OnListenerAdded.
-  scoped_ptr<ExtensionManagementEventRouter> management_event_router_;
+  scoped_ptr<ManagementEventRouter> management_event_router_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagementAPI);
 };
 
+template<>
+ProfileKeyedAPIFactory<ManagementAPI>*
+ProfileKeyedAPIFactory<ManagementAPI>::GetInstance();

[Jeffrey Yasskin, 2013/01/03 23:10:42]

Late question: Why does this need to be a method on
ProfileKeyedAPIFactory<ManagementAPI> instead of on ManagementAPI? Defining a
static method "ProfileKeyedAPIFactory<ManagementAPI>*
ManagementAPI::GetFactoryInstance()" would avoid some inscrutable template
syntax.

[Yoyo Zhou, 2013/01/03 23:52:58]

Good question. I think that's something I would add to the template also, so
I'll change it in the next CL.

+
+}  // namespace extensions
+
 #endif  // CHROME_BROWSER_EXTENSIONS_API_MANAGEMENT_MANAGEMENT_API_H_