Serialize/Deserialize support in HistogramBase

chrome/common/metrics/metrics_service_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/metrics/metrics_service_base.h"
 
 #include <cstdlib>
 
 #include "chrome/common/metrics/metrics_log_base.h"
 
@@ skipping 20 matching lines @@
     "application/vnd.chrome.uma";
 
 void MetricsServiceBase::RecordCurrentHistograms() {
   DCHECK(log_manager_.current_log());
   histogram_snapshot_manager_.PrepareDeltas(base::Histogram::kNoFlags, true);
 }
 
 void MetricsServiceBase::RecordDelta(
     const base::Histogram& histogram,
     const base::HistogramSamples& snapshot) {
-  log_manager_.current_log()->RecordHistogramDelta(histogram, snapshot);
+  log_manager_.current_log()->RecordHistogramDelta(histogram.histogram_name(),

[Ilya Sherman, 2012/12/29 00:17:30]

This is a fine change, but why is it part of this CL?

[kaiwang, 2013/01/08 00:51:40]

In this CL, I changed most of the serializing related code to use HistogramBase
instead of Histogram.
For RecordHistogramDelta, only name is used, so I directly changed it to only
depend on name.

[Ilya Sherman, 2013/01/08 22:31:53]

Ok, fair enough :)

+                                                   snapshot);
 }
 
 void MetricsServiceBase::InconsistencyDetected(
     Histogram::Inconsistencies problem) {
   UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowser",
                             problem, Histogram::NEVER_EXCEEDED_VALUE);
 }
 
 void MetricsServiceBase::UniqueInconsistencyDetected(
     Histogram::Inconsistencies problem) {
   UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowserUnique",
                             problem, Histogram::NEVER_EXCEEDED_VALUE);
 }
 
 void MetricsServiceBase::InconsistencyDetectedInLoggedCount(int amount) {
   UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotBrowser",
                        std::abs(amount));
 }