Issue 11678004: Undo change to render_view_impl.cc for crbug.com/153907 (Request Table Site not working)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11678004: Undo change to render_view_impl.cc for crbug.com/153907 (Request Table Site not working) (Closed)

Created:
7 years, 12 months ago by sschmitz

Modified:
7 years, 11 months ago

Reviewers:
jamesr

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Undo change to render_view_impl.cc for crbug.com/153907 (Request Table Site not working) Pre request from dfalcantara@: When you get a chance, can you try reverting the change you landed to render_view_impl.cc for http://crbug.com/153907 ? We ended up getting bitten by a similar bug as you guys and a fix for WebKit just landed that should address it. Solution: removed "#if defined(OS_ANDROID)" around one line of code. See also: https://chromiumcodereview.appspot.com/11227065/ BUG=166652 TEST=manual:enable "Request RTS flag" (chrome://flags "Enables the request tablet site option in the settings menu"). Navigate to something like: www.whatsmyua.com www.whatsmyuseragent.com www.espn.com www.facebook.com Under Settings toggle "Request Tablet Site". Observe the page reloading with "tablet site look". Exit and reenter chrome with one or more tabs that have RTS enabled and observe "look". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174894

Patch Set 1 #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	content/renderer/render_view_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sschmitz@chromium.org/11678004/1

7 years, 11 months ago (2013-01-02 21:42:11 UTC) #3

Message was sent while issue was closed.

Change committed as 174894

Expand Messages | Collapse Messages