Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11676005: postmortem: export kSmiShiftSize (Closed)

Created:
6 years, 11 months ago by indutny
Modified:
6 years, 11 months ago
Reviewers:
Erik Corry
Base URL:
gh:v8/v8@master
Visibility:
Public.

Description

postmortem: export kSmiShiftSize Right now it's impossible to figure out from headers that smis are left shifted by 31 bit on x64, and only then tagged. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=13285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
indutny
6 years, 11 months ago (2012-12-27 03:25:25 UTC) #1
indutny
On 2012/12/27 03:25:25, indutny wrote: Please also consider porting it to 3.13... and probably 3.14. ...
6 years, 11 months ago (2012-12-27 03:26:07 UTC) #2
Erik Corry
I think it would be more accurate to say that Smis are tagged by shifting ...
6 years, 11 months ago (2012-12-28 11:56:48 UTC) #3
Erik Corry
LGTM
6 years, 11 months ago (2012-12-28 12:00:38 UTC) #4
indutny
6 years, 11 months ago (2012-12-28 12:51:34 UTC) #5
On 2012/12/28 12:00:38, Erik Corry wrote:
> LGTM

Cool! Any chance to backport it?

Powered by Google App Engine
This is Rietveld 408576698