Issue 11673011: chromeos: Update focus ring color in WebKit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11673011: chromeos: Update focus ring color in WebKit. (Closed)

Created:
7 years, 12 months ago by Daniel Erat

Modified:
7 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Update focus ring color in WebKit. This sets WebKit's focus ring color to #4d90fe; USE_DEFAULT_RENDER_THEME-defining builds like Chrome OS appear to have been previously using the default of #e59700 from RenderThemeChromiumSkia. It also makes RenderViewImpl honor the caret blink interval for USE_DEFAULT_RENDER_THEME instead of just for GTK. BUG=153080 TEST=manual: focus rings are blue instead of orange Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174881

Patch Set 1 #

Patch Set 2 : change assignment order to match gtk block #

Patch Set 3 : move WebRenderTheme.h include outside of ifdef #

Patch Set 4 : merge #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
	M	chrome/browser/renderer_preferences_util.cc	View	1	2 chunks	+9 lines, -8 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View	1 2 3	4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11673011/5001

7 years, 11 months ago (2013-01-02 19:34:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11673011/18001

7 years, 11 months ago (2013-01-02 20:18:21 UTC) #4

Message was sent while issue was closed.

Change committed as 174881

Expand Messages | Collapse Messages