Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui.web/src/com/google/dart/tools/ui/web/html/HtmlTagScanner.java

Issue 11673007: Improve our html editor; add syntax highlighting for script tags; hyperlink detection and navigatio… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui.web/src/com/google/dart/tools/ui/web/html/HtmlTagScanner.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.ui.web/src/com/google/dart/tools/ui/web/html/HtmlTagScanner.java (revision 16584)
+++ editor/tools/plugins/com.google.dart.tools.ui.web/src/com/google/dart/tools/ui/web/html/HtmlTagScanner.java (working copy)
@@ -27,6 +27,9 @@
import org.eclipse.jface.text.rules.WhitespaceRule;
import org.eclipse.swt.SWT;
+import java.util.ArrayList;
+import java.util.List;
+
class HtmlTagScanner extends RuleBasedScanner {
public HtmlTagScanner() {
@@ -37,10 +40,10 @@
IToken procInstr = new Token(new TextAttribute(DartWebPlugin.getPlugin().getEditorColor(
DartWebPlugin.COLOR_ALT_COMMENTS)));
- IRule[] rules = new IRule[5];
+ List<IRule> rules = new ArrayList<IRule>();
- rules[0] = new SingleLineRule("\"", "\"", stringToken, '\\');
- rules[1] = new SingleLineRule("'", "'", stringToken, '\\');
+ rules.add(new SingleLineRule("\"", "\"", stringToken, '\\'));
+ rules.add(new SingleLineRule("'", "'", stringToken, '\\'));
HtmlWordRule keywordRule = new HtmlWordRule(new WordDetector(), true);
@@ -48,12 +51,11 @@
keywordRule.addWord(keyword, keywordToken);
}
- rules[2] = keywordRule;
+ rules.add(keywordRule);
- rules[3] = new SingleLineRule("<?", "?>", procInstr);
- rules[4] = new WhitespaceRule(new WhitespaceDetector());
+ rules.add(new SingleLineRule("<?", "?>", procInstr));
+ rules.add(new WhitespaceRule(new WhitespaceDetector()));
- setRules(rules);
+ setRules(rules.toArray(new IRule[rules.size()]));
}
-
}

Powered by Google App Engine
This is Rietveld 408576698