editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java - Issue 11673007: Improve our html editor; add syntax highlighting for script tags; hyperlink detection and navigatio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java

Issue 11673007: Improve our html editor; add syntax highlighting for script tags; hyperlink detection and navigatio… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlKeywords.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java

===================================================================

--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java (revision 16584)

+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/html/HtmlBuildParticipant.java (working copy)

@@ -109,12 +109,17 @@

if (!validAttributes.isEmpty()) {

for (XmlAttribute attribute : node.getAttributes()) {

String name = attribute.getName();

// A common pattern with data-binding frameworks.

if (name.startsWith("ng-")) {

continue;

}

+ // A data attribute.

+ if (name.startsWith("data-")) {

+ continue;

+ }

if (!validAttributes.contains(name)) {

if (!HtmlKeywords.isValidEventAttribute(name)) {

int charStart = attribute.getStartToken().getLocation();