Disabled transparency for header bars on the signin screen.

Disabled transparency for header bars on the signin screen.

BUG=131242
TEST=Tested on Linux ChromeOS build


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175779

[ygorshenin1, 2012-12-27 14:08:17]

PTAL

[Nikita (slow), 2012-12-27 15:22:19]

lgtm

https://codereview.chromium.org/11673006/diff/2001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_display_host.cc (right):

https://codereview.chromium.org/11673006/diff/2001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_display_host.cc:382:
root->SetProperty(ash::internal::kIgnoreSoloWindowPolicy, true);
nit: Save previous value and then restore it?

[ygorshenin1, 2012-12-27 15:37:35]

PTAL

https://codereview.chromium.org/11673006/diff/2001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_display_host.cc (right):

https://codereview.chromium.org/11673006/diff/2001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_display_host.cc:382:
root->SetProperty(ash::internal::kIgnoreSoloWindowPolicy, true);
On 2012/12/27 15:22:19, Nikita Kostylev wrote:
> nit: Save previous value and then restore it?

Done.

[Daniel Erat, 2012-12-27 17:44:45]

Just wondering: does it make more sense to assign this property to the window
that shouldn't get the solo window frame itself rather than to the root?

https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h...
ash/wm/window_properties.h:39: kIgnoreSoloWindowPolicy;
nit: rename this to something like kIgnoreSoloWindowFramePainterPolicy so it's
more clear what it refers to

https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_display_host.h (right):

https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_display_host.h:77: void
InitLoginWindowAndView();
nit: add comments describing what these do

[ygorshenin1, 2012-12-28 07:46:45]

On 2012/12/27 17:44:45, Daniel Erat wrote:
> Just wondering: does it make more sense to assign this property to the window
> that shouldn't get the solo window frame itself rather than to the root?
>

I think no, because in this case we need to set this property to each window in
the login container (proxy settings dialog, captive portal window, ...). 

> https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h
> File ash/wm/window_properties.h (right):
> 
>
https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h...
> ash/wm/window_properties.h:39: kIgnoreSoloWindowPolicy;
> nit: rename this to something like kIgnoreSoloWindowFramePainterPolicy so it's
> more clear what it refers to
> 
>
https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
> File chrome/browser/chromeos/login/webui_login_display_host.h (right):
> 
>
https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
> chrome/browser/chromeos/login/webui_login_display_host.h:77: void
> InitLoginWindowAndView();
> nit: add comments describing what these do

[ygorshenin1, 2012-12-28 07:46:55]

PTAL

https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/11673006/diff/5002/ash/wm/window_properties.h...
ash/wm/window_properties.h:39: kIgnoreSoloWindowPolicy;
On 2012/12/27 17:44:45, Daniel Erat wrote:
> nit: rename this to something like kIgnoreSoloWindowFramePainterPolicy so it's
> more clear what it refers to

Done.

https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_display_host.h (right):

https://codereview.chromium.org/11673006/diff/5002/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_display_host.h:77: void
InitLoginWindowAndView();
On 2012/12/27 17:44:45, Daniel Erat wrote:
> nit: add comments describing what these do

Done.

[Daniel Erat, 2012-12-28 15:22:47]

lgtm

[commit-bot: I haz the power, 2012-12-29 11:22:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/11673006/8001

[commit-bot: I haz the power, 2012-12-29 13:19:42]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-09 08:16:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/11673006/8001

[commit-bot: I haz the power, 2013-01-09 11:09:03]

Change committed as 175779