Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.js

Issue 11672007: Fixed header bar UI behaviour. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Logging cleanup. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.js
diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
index ce7b6c4d76aea10d30fd694c02cca9ee1b261c01..5fea2004d694163bd8dd2c871186686482350f34 100644
--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
@@ -13,15 +13,6 @@ cr.define('login', function() {
// Maximum Gaia loading time in seconds.
/** @const */ var MAX_GAIA_LOADING_TIME_SEC = 60;
- // Network state constants.
- /** @const */ var NET_STATE = {
- OFFLINE: 0,
- ONLINE: 1,
- PORTAL: 2,
- CONNECTING: 3,
- UNKNOWN: 4
- };
-
// Frame loading errors.
/** @const */ var NET_ERROR = {
ABORTED_BY_USER: 3
@@ -185,7 +176,7 @@ cr.define('login', function() {
*/
onBeforeShow: function(data) {
chrome.send('loginUIStateChanged', ['gaia-signin', true]);
- $('login-header-bar').signinUIActive = true;
+ $('login-header-bar').signinUIState = SIGNIN_UI_STATE.GAIA_SIGNIN;
// Announce the name of the screen, if accessibility is on.
$('gaia-signin-aria-label').setAttribute(
@@ -201,7 +192,7 @@ cr.define('login', function() {
*/
onBeforeHide: function() {
chrome.send('loginUIStateChanged', ['gaia-signin', false]);
- $('login-header-bar').signinUIActive = false;
+ $('login-header-bar').signinUIState = SIGNIN_UI_STATE.HIDDEN;
},
/**
@@ -359,7 +350,7 @@ cr.define('login', function() {
// Show 'Cancel' button to allow user to return to the main screen
// (e.g. this makes sense when connection is back).
Oobe.getInstance().headerHidden = false;
- $('login-header-bar').signinUIActive = true;
+ $('login-header-bar').signinUIState = SIGNIN_UI_STATE.GAIA_SIGNIN;
// Do nothing, since offline version is reloaded after an error comes.
} else {
Oobe.showSigninUI();

Powered by Google App Engine
This is Rietveld 408576698