Fixed header bar UI behaviour.

Fixed header bar UI behaviour.

BUG=167651
TEST=Manual tests on Linux ChromeOS build and Lumpy.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175818

[ygorshenin1, 2012-12-28 11:50:38]

+ Nikita

[dpolukhin, 2012-12-28 12:00:08]

I'm not familiar with this code so it will be better if Nikita reviews this CL.

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:538:
$('login-header-bar').signinUIState = SIGNIN_UI_STATE.GAIA_SIGNIN;
it looks like it is 2 idents here should 1.

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/header_bar.js (right):

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/header_bar.js:136: * @param {number}
state Current state of the sign-in screen (see
Please use @type {number}.

[ygorshenin1, 2012-12-28 12:04:54]

Nikita, PTAL.

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:538:
$('login-header-bar').signinUIState = SIGNIN_UI_STATE.GAIA_SIGNIN;
On 2012/12/28 12:00:09, dpolukhin wrote:
> it looks like it is 2 idents here should 1.

Done.

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/header_bar.js (right):

https://codereview.chromium.org/11672007/diff/2001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/header_bar.js:136: * @param {number}
state Current state of the sign-in screen (see
On 2012/12/28 12:00:09, dpolukhin wrote:
> Please use @type {number}.

Done.

[Nikita (slow), 2013-01-09 14:07:21]

lgtm

https://chromiumcodereview.appspot.com/11672007/diff/7001/chrome/browser/reso...
File chrome/browser/resources/chromeos/login/header_bar.js (right):

https://chromiumcodereview.appspot.com/11672007/diff/7001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/header_bar.js:140: console.error('set
signinUIState(' + state + ')');
nit: cleanup logging

https://chromiumcodereview.appspot.com/11672007/diff/7001/chrome/browser/reso...
chrome/browser/resources/chromeos/login/header_bar.js:159:
console.error('updateUI_: signinUIState_=' + this.signinUIState_);
nit: cleanup logging

[ygorshenin1, 2013-01-09 14:32:56]

Many thanks!

https://codereview.chromium.org/11672007/diff/7001/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/header_bar.js (right):

https://codereview.chromium.org/11672007/diff/7001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/header_bar.js:140: console.error('set
signinUIState(' + state + ')');
On 2013/01/09 14:07:21, Nikita Kostylev wrote:
> nit: cleanup logging

Done.

https://codereview.chromium.org/11672007/diff/7001/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/header_bar.js:159:
console.error('updateUI_: signinUIState_=' + this.signinUIState_);
On 2013/01/09 14:07:21, Nikita Kostylev wrote:
> nit: cleanup logging

Done.

[commit-bot: I haz the power, 2013-01-09 14:33:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/11672007/11001

[commit-bot: I haz the power, 2013-01-09 16:58:33]

Change committed as 175818