Do not return profile unless it is loaded

Do not return profile unless it is loaded

BUG=148878
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176083

[Denis Kuznetsov (DE-MUC), 2013-01-09 13:39:47]

Dave Moore for chrome/browser/profiles/ - return default profile if user profile
is not loaded yet (NOTIFICATION_LOGIN_USER_CHANGED will be sent once it finally
happens).

Nikita for chrome/browser/chromeos/ - just a ToDo.

[Nikita (slow), 2013-01-09 13:54:32]

lgtm

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/chr...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/chr...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:509: // usually go after
NOTIFICATION_LOGIN_USER_PROFILE_PREPARED, which requires
NOTIFICATION_LOGIN_USER_PROFILE_PREPARED is called from
LoginUtilsImpl::FinalizePrepareProfile() in case of async user profile loading
i.e. normal login path.

Please expand this TODO  to also emit NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
for restart after browser crash that happens inside user session i.e.
synchronous load of user profile.

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
File chrome/browser/profiles/profile_manager.cc (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
chrome/browser/profiles/profile_manager.cc:367: // Fallback to actual initial
profile, if profile for user was not fully
nit: "actual initial profile" > "default OTR login profile" to match comment
above and to be more specific.

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
File chrome/browser/profiles/profile_manager.h (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
chrome/browser/profiles/profile_manager.h:266: ProfileInfo*
GetProfileInfoByPath(const FilePath& path) const;
nit: comment

[Denis Kuznetsov (DE-MUC), 2013-01-09 14:10:49]

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/chr...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/chr...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:509: // usually go after
NOTIFICATION_LOGIN_USER_PROFILE_PREPARED, which requires
On 2013/01/09 13:54:33, Nikita Kostylev wrote:
> NOTIFICATION_LOGIN_USER_PROFILE_PREPARED is called from
> LoginUtilsImpl::FinalizePrepareProfile() in case of async user profile loading
> i.e. normal login path.
> 
> Please expand this TODO  to also emit NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> for restart after browser crash that happens inside user session i.e.
> synchronous load of user profile.

Done.

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
File chrome/browser/profiles/profile_manager.cc (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
chrome/browser/profiles/profile_manager.cc:367: // Fallback to actual initial
profile, if profile for user was not fully
On 2013/01/09 13:54:33, Nikita Kostylev wrote:
> nit: "actual initial profile" > "default OTR login profile" to match comment
> above and to be more specific.

Done.

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
File chrome/browser/profiles/profile_manager.h (right):

https://chromiumcodereview.appspot.com/11667024/diff/31003/chrome/browser/pro...
chrome/browser/profiles/profile_manager.h:266: ProfileInfo*
GetProfileInfoByPath(const FilePath& path) const;
On 2013/01/09 13:54:33, Nikita Kostylev wrote:
> nit: comment

Done.

[DaveMoore, 2013-01-09 17:58:12]

lgtm

[commit-bot: I haz the power, 2013-01-09 18:47:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11667024/39004

[commit-bot: I haz the power, 2013-01-09 18:59:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Nikita (slow), 2013-01-10 10:30:59]

Makes sense to run cros_* trybots. I'll execute them for now.

[Denis Kuznetsov (DE-MUC), 2013-01-10 10:43:59]

On 2013/01/10 10:30:59, Nikita Kostylev wrote:
> Makes sense to run cros_* trybots. I'll execute them for now.

Ran them on patch set #7, only comments have changed since.

[commit-bot: I haz the power, 2013-01-10 11:17:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11667024/39004

[commit-bot: I haz the power, 2013-01-10 11:45:40]

Retried try job too often on win_rel for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-10 12:55:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/11667024/39004

[commit-bot: I haz the power, 2013-01-10 14:56:33]

Change committed as 176083