Convert all symbols accessor to return read only handles so that it is not necessary to create a ne…

vm/flow_graph_compiler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 782 matching lines @@
     // stack.
     __ addl(ESP, Immediate(StackSize() * kWordSize));
   }
   // The call below has an empty stackmap because we have just
   // dropped the spill slots.
   BitmapBuilder* empty_stack_bitmap = new BitmapBuilder();
 
   // Invoke noSuchMethod function passing the original name of the function.
   // If the function is a closure function, use "call" as the original name.
   const String& name = String::Handle(
-      function.IsClosureFunction() ? Symbols::Call() : function.name());
+      function.IsClosureFunction() ? Symbols::Call().raw() : function.name());
   const int kNumArgsChecked = 1;
   const ICData& ic_data = ICData::ZoneHandle(
       ICData::New(function, name, Isolate::kNoDeoptId, kNumArgsChecked));
   __ LoadObject(ECX, ic_data);
   // EBP - 4 : PC marker, allows easy identification of RawInstruction obj.
   // EBP : points to previous frame pointer.
   // EBP + 4 : points to return address.
   // EBP + 8 : address of last argument (arg n-1).
   // ESP + 8 + 4*(n-1) : address of first argument (arg 0).
   // ECX : ic-data.
@@ skipping 113 matching lines @@
           // We need to unwind the space we reserved for locals and copied
           // parameters. The NoSuchMethodFunction stub does not expect to see
           // that area on the stack.
           __ addl(ESP, Immediate(StackSize() * kWordSize));
         }
         // The call below has an empty stackmap because we have just
         // dropped the spill slots.
         BitmapBuilder* empty_stack_bitmap = new BitmapBuilder();
 
         // Invoke noSuchMethod function passing "call" as the function name.
-        const String& name = String::Handle(Symbols::Call());
         const int kNumArgsChecked = 1;
         const ICData& ic_data = ICData::ZoneHandle(
-            ICData::New(function, name, Isolate::kNoDeoptId, kNumArgsChecked));
+            ICData::New(function, Symbols::Call(),
+                        Isolate::kNoDeoptId, kNumArgsChecked));
         __ LoadObject(ECX, ic_data);
         // EBP - 4 : PC marker, for easy identification of RawInstruction obj.
         // EBP : points to previous frame pointer.
         // EBP + 4 : points to return address.
         // EBP + 8 : address of last argument (arg n-1).
         // ESP + 8 + 4*(n-1) : address of first argument (arg 0).
         // ECX : ic-data.
         // EDX : arguments descriptor array.
         __ call(&StubCode::CallNoSuchMethodFunctionLabel());
         if (is_optimizing()) {
@@ skipping 553 matching lines @@
   __ popl(ECX);
   __ popl(EAX);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32