Improves CoreAudioUtil::IsSupported by also loading Audioses.dll DLL

Improves CoreAudioUtil::IsSupported by also loading Audioses.dll DLL


BUG=166397
TEST=media_unittests and manual tests in Chrome where I force DLL load to fail.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174373

[henrika (OOO until Aug 14), 2012-12-21 09:50:33]

Tommi, as we discussed.

[tommi (sloooow) - chröme, 2012-12-21 09:58:14]

lgtm with some minor nits.

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:75: if (!LoadLibraryExW(path, NULL,
LOAD_WITH_ALTERED_SEARCH_PATH))
return LoadLibraryExW(path, NULL, LOAD_WITH_ALTERED_SEARCH_PATH)) != NULL;

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:122: // system components, both of which
run in user mode.
nit: dll's generally do run in usermode so you can remove that bit :)

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:123: // Dependcy Walker shows that it is
enough to verify possibility to load
Dependency

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:124: // the Audioses DLL since it loads
Mmdevapi.dll as well.
s/it loads Mmdevapi.dll as well/it depends on Mmdevapi.dll.
The loader loads the dlls, they don't do it themselves.

[henrika (OOO until Aug 14), 2012-12-21 10:03:35]

Done.

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:75: if (!LoadLibraryExW(path, NULL,
LOAD_WITH_ALTERED_SEARCH_PATH))
OK. I followed your example BTW ;-)

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:122: // system components, both of which
run in user mode.
Got it. Copy paste from MSDN.

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:123: // Dependcy Walker shows that it is
enough to verify possibility to load
On 2012/12/21 09:58:14, tommi wrote:
> Dependency

Done.

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:124: // the Audioses DLL since it loads
Mmdevapi.dll as well.
Thanks. Much better.

[commit-bot: I haz the power, 2012-12-21 10:06:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/11666005/6001

[tommi (sloooow) - chröme, 2012-12-21 10:29:17]

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/11666005/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:75: if (!LoadLibraryExW(path, NULL,
LOAD_WITH_ALTERED_SEARCH_PATH))
On 2012/12/21 10:03:36, henrika wrote:
> OK. I followed your example BTW ;-)

Hah, well, you should have noticed that in the other case there was a loop! :)
Think about how this would have worked:

  for (int i = 0; i < arraysize(kMfDLLs); ++i) {
    wchar_t path[MAX_PATH] = {0};
    ExpandEnvironmentStringsW(kMfDLLs[i], path, arraysize(path));
    return LoadLibraryExW(path, NULL, LOAD_WITH_ALTERED_SEARCH_PATH)) != NULL;
  }

[commit-bot: I haz the power, 2012-12-21 12:04:10]

Change committed as 174373