Issue 11665007: Fix x64 MathMinMax for negative untagged int32 arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11665007: Fix x64 MathMinMax for negative untagged int32 arguments. (Closed)

Created:
8 years ago by ulan

Modified:
8 years ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix x64 MathMinMax for negative untagged int32 arguments. An untagged int32 has zeros in the upper half even if it is negative. Using cmpq to compare such numbers will incorrectly ignore the sign. BUG=164442 R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13273

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-164442.js	View		1 chunk	+9 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm