sdk/lib/_internal/compiler/implementation/closure.dart - Issue 11664006: Make Map.keys/values Iterables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/closure.dart

Issue 11664006: Make Map.keys/values Iterables. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Add TODO that map.keys should return a Set. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/closure.dart

diff --git a/sdk/lib/_internal/compiler/implementation/closure.dart b/sdk/lib/_internal/compiler/implementation/closure.dart

index 7f3df99eab0e8522bb2d049ff3675bf29c02dbb2..201817f3dfa03c966db0b5326e897a60dcc71b30 100644

--- a/sdk/lib/_internal/compiler/implementation/closure.dart

+++ b/sdk/lib/_internal/compiler/implementation/closure.dart

@@ -614,7 +614,7 @@ class ClosureTranslator extends Visitor {

currentElement = oldFunctionElement;

// Mark all free variables as captured and use them in the outer function.

- List<Element> freeVariables = savedClosureData.freeVariableMapping.keys;

+ Iterable<Element> freeVariables = savedClosureData.freeVariableMapping.keys;

assert(freeVariables.isEmpty || savedInsideClosure);

for (Element freeElement in freeVariables) {

if (capturedVariableMapping[freeElement] != null &&