pkg/serialization/lib/src/serialization_rule.dart - Issue 11664006: Make Map.keys/values Iterables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/serialization/lib/src/serialization_rule.dart

Issue 11664006: Make Map.keys/values Iterables. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Add TODO that map.keys should return a Set. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/serialization/lib/src/serialization_rule.dart

diff --git a/pkg/serialization/lib/src/serialization_rule.dart b/pkg/serialization/lib/src/serialization_rule.dart

index 1f64cf07953a2715cdce208f290428528cd4358b..1a68075490d5bc81fc9db84ab10d2f5a4b1e1d4c 100644

--- a/pkg/serialization/lib/src/serialization_rule.dart

+++ b/pkg/serialization/lib/src/serialization_rule.dart

@@ -516,14 +516,14 @@ class _LazyMap implements Map {

int get length => _raw.length;

bool get isEmpty => _raw.isEmpty;

- List get keys => _raw.keys;

+ Iterable get keys => _raw.keys;

bool containsKey(x) => _raw.containsKey(x);

// These operations will work, but may be expensive, and are probably

// best avoided.

get _inflated => keysAndValues(_raw).map(_reader.inflateReference);

bool containsValue(x) => _inflated.containsValue(x);

- List get values => _inflated.values;

+ Iterable get values => _inflated.values;

void forEach(f) => _inflated.forEach(f);

// These operations are all invalid