Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11663025: Added JavaScript API Test for getFileSyncStatus() function. (Closed)

Created:
7 years, 12 months ago by calvinlo
Modified:
7 years, 11 months ago
Reviewers:
benwells, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Added JavaScript API Test for getFileSyncStatus() function. BUG=163860 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175505

Patch Set 1 #

Patch Set 2 : Revised using order #

Total comments: 2

Patch Set 3 : tzik review #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
calvinlo
Hi Taiju San, can you please take a first look before I send to Benwells ...
7 years, 12 months ago (2012-12-25 07:18:20 UTC) #1
tzik
https://codereview.chromium.org/11663025/diff/2001/chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js File chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js (right): https://codereview.chromium.org/11663025/diff/2001/chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js#newcode30 chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js:30: testStep[0] s/testStep[0]/testStep.shift()/
7 years, 12 months ago (2012-12-25 09:14:41 UTC) #2
calvinlo
7 years, 12 months ago (2012-12-25 10:22:46 UTC) #3
calvinlo
https://codereview.chromium.org/11663025/diff/2001/chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js File chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js (right): https://codereview.chromium.org/11663025/diff/2001/chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js#newcode30 chrome/test/data/extensions/api_test/sync_file_system/get_file_sync_status/test.js:30: testStep[0] On 2012/12/25 09:14:42, tzik wrote: > s/testStep[0]/testStep.shift()/ Done.
7 years, 12 months ago (2012-12-25 10:23:47 UTC) #4
tzik
lgtm
7 years, 12 months ago (2012-12-25 11:44:07 UTC) #5
calvinlo
Hi Ben, I think this is ready for you to look at for extension/ ownership. ...
7 years, 12 months ago (2012-12-25 11:53:41 UTC) #6
benwells
lgtm
7 years, 11 months ago (2013-01-03 00:55:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/11663025/5
7 years, 11 months ago (2013-01-07 07:27:27 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 07:41:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calvinlo@chromium.org/11663025/5
7 years, 11 months ago (2013-01-08 04:36:18 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 09:01:45 UTC) #11
Message was sent while issue was closed. 
Change committed as 175505

Powered by Google App Engine
This is Rietveld 408576698