[Android WebView] Count the number of HTTP auth attempts we make.

[Android WebView] Count the number of HTTP auth attempts we make.

Add a user data key to UrlRequests requiring HTTP auth in the
Android WebView. This is used to implement the Android
HttpAuthHandler.useHttpAuthUsernamePassword API.

Android only change and android bots are green.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174436

[benm (inactive), 2012-12-21 16:42:23]

ptal

[joth, 2012-12-21 18:59:43]

lgtm

+cheeky request to fix my TODO while you're here, but feel free to land this
patch as is if you prefer.

https://codereview.chromium.org/11663006/diff/1/android_webview/java/src/org/...
File
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java
(right):

https://codereview.chromium.org/11663006/diff/1/android_webview/java/src/org/...
android_webview/java/src/org/chromium/android_webview/AwHttpAuthHandler.java:14:
private boolean mFirstAttempt;
could make this final.

mNativeAwHttpAuthHandler can't be as we should be zeroing it out when the native
side is destroyed:

@CalledByNative
void handlerDestroyed() {
   mNativeAwHttpAuthHandler = 0;
} 

then need to make proceed() & cancel() into no-ops if mNativeAwHttpAuthHandler
is 0

https://codereview.chromium.org/11663006/diff/1/android_webview/native/aw_htt...
File android_webview/native/aw_http_auth_handler.cc (right):

https://codereview.chromium.org/11663006/diff/1/android_webview/native/aw_htt...
android_webview/native/aw_http_auth_handler.cc:32: // TODO(joth): tell java
counterpart, so it can null its native back-pointer.
call Java_AwHttpAuthHandler_handerDestroyed();

[benm (inactive), 2012-12-21 19:46:06]

Thanks Joth!

Marking CQ now in the interest of not leaving this over the holidays, but left
myself a sticky note to add the destruction handler in the new year!

[commit-bot: I haz the power, 2012-12-21 19:46:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/11663006/1

[commit-bot: I haz the power, 2012-12-21 19:47:11]

Change committed as 174436

[joth, 2012-12-21 23:01:59]

On 2012/12/21 19:46:06, benm wrote:
> Thanks Joth!
> 
> Marking CQ now in the interest of not leaving this over the holidays, but left
> myself a sticky note to add the destruction handler in the new year!

It's ok - I got it https://codereview.chromium.org/11661013/  :)

Thanks