Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 11662014: Implement new network change notifier that uses NetworkStateHandler (Closed)

Created:
8 years ago by gauravsh
Modified:
8 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement new network change notifier that uses NetworkStateHandler [Reland of https://codereview.chromium.org/11469044/ with rebase over changes to the new network state handler.] This implements the new network change notifier that informs the Chrome network stack of connectivity changes. It's currently behind the --enable-new-network-handlers command line flag. BUG=chromium-os:159647 TEST=unit tests, gmerged on a device and ensured offline->online and online->offline transitions are correctly detected. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -5 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 6 chunks +23 lines, -5 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +5 lines, -0 lines 0 comments Download
M chromeos/network/managed_state.h View 1 chunk +2 lines, -0 lines 0 comments Download
A chromeos/network/network_change_notifier_chromeos.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chromeos/network/network_change_notifier_chromeos.cc View 1 chunk +191 lines, -0 lines 0 comments Download
A chromeos/network/network_change_notifier_chromeos_unittest.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A chromeos/network/network_change_notifier_factory_chromeos.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chromeos/network/network_change_notifier_factory_chromeos.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chromeos/network/network_state.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gauravsh
8 years ago (2012-12-21 21:15:42 UTC) #1
stevenjb
lgtm
8 years ago (2012-12-21 21:20:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11662014/1
8 years ago (2012-12-21 21:39:17 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-22 01:08:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11662014/1
8 years ago (2012-12-22 02:35:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-22 06:41:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/11662014/1
8 years ago (2012-12-22 08:25:22 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-22 17:22:27 UTC) #8
Message was sent while issue was closed.
Change committed as 174530

Powered by Google App Engine
This is Rietveld 408576698