chrome/common/extensions/api/omnibox/omnibox_handler.cc - Issue 11662013: Move Commands from Extension to CommandsHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/omnibox/omnibox_handler.cc

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/api/omnibox/omnibox_handler.cc

diff --git a/chrome/common/extensions/api/omnibox/omnibox_handler.cc b/chrome/common/extensions/api/omnibox/omnibox_handler.cc

index 941bdd329fee3bd008a27513068caf6d563279c4..ece5388b51c023dcaaa441a7cf0282c1c273a5e6 100644

--- a/chrome/common/extensions/api/omnibox/omnibox_handler.cc

+++ b/chrome/common/extensions/api/omnibox/omnibox_handler.cc

@@ -8,6 +8,7 @@

#include "base/string_util.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

+#include "chrome/common/extensions/api/commands/commands_handler.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

@@ -32,7 +33,7 @@ bool OmniboxInfo::IsVerboseInstallMessage(const Extension* extension) {

return !GetKeyword(extension).empty() ||

extension->browser_action_info() ||

(extension->page_action_info() &&

- (extension->page_action_command() ||

+ (CommandsInfo::GetPageActionCommand(extension) ||

!extension->page_action_info()->default_icon.empty()));

}