Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6631)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_function_registry.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
index 0e54d294278f836821a95b5b9ca1f6f3a81a8c8a..64eb7013fe00d3df7c866ed3000370c384509200 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
@@ -25,6 +25,7 @@
#include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/api/commands/commands_handler.h"
#include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/url_constants.h"
@@ -297,7 +298,7 @@ class ExtensionLoadedNotificationObserver
extensions::CommandService* command_service =
extensions::CommandService::Get(browser_->profile());
if (type_ == extension_installed_bubble::kPageAction) {
- if (extension_->page_action_command() &&
+ if (extensions::CommandsInfo::GetPageActionCommand(extension_) &&
command_service->GetPageActionCommand(
extension_->id(),
extensions::CommandService::ACTIVE_ONLY,
@@ -314,7 +315,7 @@ class ExtensionLoadedNotificationObserver
extensions::CommandService* command_service =
extensions::CommandService::Get(browser_->profile());
if (type_ == extension_installed_bubble::kBrowserAction) {
- if (extension_->browser_action_command() &&
+ if (extensions::CommandsInfo::GetBrowserActionCommand(extension_) &&
command_service->GetBrowserActionCommand(
extension_->id(),
extensions::CommandService::ACTIVE_ONLY,
« no previous file with comments | « chrome/browser/extensions/extension_function_registry.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698