Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controlle r.h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controlle r.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/mac/bundle_locations.h" 8 #include "base/mac/bundle_locations.h"
9 #include "base/mac/mac_util.h" 9 #include "base/mac/mac_util.h"
10 #include "base/sys_string_conversions.h" 10 #include "base/sys_string_conversions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "chrome/browser/extensions/api/commands/command_service.h" 12 #include "chrome/browser/extensions/api/commands/command_service.h"
13 #include "chrome/browser/extensions/bundle_installer.h" 13 #include "chrome/browser/extensions/bundle_installer.h"
14 #include "chrome/browser/extensions/extension_action.h" 14 #include "chrome/browser/extensions/extension_action.h"
15 #include "chrome/browser/extensions/extension_action_manager.h" 15 #include "chrome/browser/extensions/extension_action_manager.h"
16 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_navigator.h" 17 #include "chrome/browser/ui/browser_navigator.h"
18 #include "chrome/browser/ui/browser_window.h" 18 #include "chrome/browser/ui/browser_window.h"
19 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 19 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
20 #include "chrome/browser/ui/cocoa/browser_window_controller.h" 20 #include "chrome/browser/ui/cocoa/browser_window_controller.h"
21 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 21 #include "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
22 #include "chrome/browser/ui/cocoa/hover_close_button.h" 22 #include "chrome/browser/ui/cocoa/hover_close_button.h"
23 #include "chrome/browser/ui/cocoa/info_bubble_view.h" 23 #include "chrome/browser/ui/cocoa/info_bubble_view.h"
24 #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 24 #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
25 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" 25 #include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
26 #include "chrome/browser/ui/singleton_tabs.h" 26 #include "chrome/browser/ui/singleton_tabs.h"
27 #include "chrome/common/chrome_notification_types.h" 27 #include "chrome/common/chrome_notification_types.h"
28 #include "chrome/common/extensions/api/commands/commands_handler.h"
28 #include "chrome/common/extensions/api/omnibox/omnibox_handler.h" 29 #include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
29 #include "chrome/common/extensions/extension.h" 30 #include "chrome/common/extensions/extension.h"
30 #include "chrome/common/url_constants.h" 31 #include "chrome/common/url_constants.h"
31 #include "content/public/browser/notification_details.h" 32 #include "content/public/browser/notification_details.h"
32 #include "content/public/browser/notification_registrar.h" 33 #include "content/public/browser/notification_registrar.h"
33 #include "content/public/browser/notification_source.h" 34 #include "content/public/browser/notification_source.h"
34 #include "grit/chromium_strings.h" 35 #include "grit/chromium_strings.h"
35 #include "grit/generated_resources.h" 36 #include "grit/generated_resources.h"
36 #import "skia/ext/skia_utils_mac.h" 37 #import "skia/ext/skia_utils_mac.h"
37 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h" 38 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 } 291 }
291 [iconImage_ setImage:icon_]; 292 [iconImage_ setImage:icon_];
292 [iconImage_ setNeedsDisplay:YES]; 293 [iconImage_ setNeedsDisplay:YES];
293 return window; 294 return window;
294 } 295 }
295 296
296 - (bool)hasActivePageAction:(extensions::Command*)command { 297 - (bool)hasActivePageAction:(extensions::Command*)command {
297 extensions::CommandService* command_service = 298 extensions::CommandService* command_service =
298 extensions::CommandService::Get(browser_->profile()); 299 extensions::CommandService::Get(browser_->profile());
299 if (type_ == extension_installed_bubble::kPageAction) { 300 if (type_ == extension_installed_bubble::kPageAction) {
300 if (extension_->page_action_command() && 301 if (extensions::CommandsInfo::GetPageActionCommand(extension_) &&
301 command_service->GetPageActionCommand( 302 command_service->GetPageActionCommand(
302 extension_->id(), 303 extension_->id(),
303 extensions::CommandService::ACTIVE_ONLY, 304 extensions::CommandService::ACTIVE_ONLY,
304 command, 305 command,
305 NULL)) { 306 NULL)) {
306 return true; 307 return true;
307 } 308 }
308 } 309 }
309 310
310 return false; 311 return false;
311 } 312 }
312 313
313 - (bool)hasActiveBrowserAction:(extensions::Command*)command { 314 - (bool)hasActiveBrowserAction:(extensions::Command*)command {
314 extensions::CommandService* command_service = 315 extensions::CommandService* command_service =
315 extensions::CommandService::Get(browser_->profile()); 316 extensions::CommandService::Get(browser_->profile());
316 if (type_ == extension_installed_bubble::kBrowserAction) { 317 if (type_ == extension_installed_bubble::kBrowserAction) {
317 if (extension_->browser_action_command() && 318 if (extensions::CommandsInfo::GetBrowserActionCommand(extension_) &&
318 command_service->GetBrowserActionCommand( 319 command_service->GetBrowserActionCommand(
319 extension_->id(), 320 extension_->id(),
320 extensions::CommandService::ACTIVE_ONLY, 321 extensions::CommandService::ACTIVE_ONLY,
321 command, 322 command,
322 NULL)) { 323 NULL)) {
323 return true; 324 return true;
324 } 325 }
325 } 326 }
326 327
327 return false; 328 return false;
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 - (IBAction)onManageShortcutClicked:(id)sender { 564 - (IBAction)onManageShortcutClicked:(id)sender {
564 [self close]; 565 [self close];
565 std::string configure_url = chrome::kChromeUIExtensionsURL; 566 std::string configure_url = chrome::kChromeUIExtensionsURL;
566 configure_url += chrome::kExtensionConfigureCommandsSubPage; 567 configure_url += chrome::kExtensionConfigureCommandsSubPage;
567 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 568 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
568 browser_, GURL(configure_url))); 569 browser_, GURL(configure_url)));
569 chrome::Navigate(&params); 570 chrome::Navigate(&params);
570 } 571 }
571 572
572 @end 573 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698